Add UMA for push permission disabled in WebAPKs |
|||||
Issue descriptionCurrently if users disable the push permission in Android Settings for WebAPKs, Chrome isn't aware of this so can't reflect it in Chrome's permissions, can't unsubscribe from GCM etc. This results in sites with Notifications disabled in Android, but enabled in Chrome being able to send push messages that run script but never show a notification which is obviously very undesirable. Resolving that high level issue is fairly urgent, I suggest for M57 we implement UMA to record whenever a user disables notifications from a WebAPK so we can at least begin to understand this issue. Assigning to Sam for prioritization and triage, cc beverloo who can add anything I missed.
,
Jan 27 2017
(Owen, please use peter@.) Having *no* engagement with notifications is unexpected, since developers receive a `notificationclose` event in addition to the `notificationclick` event as well. We currently measure this each time a notification is being shown. Following that pattern for WebAPKs would be grand.
,
Aug 28 2017
We've also want to start measuring engagement with WebApk features outside of launches. This nicely fits in that bucket (e.g. user disabled the webapk permission as opposed to breaking all push permissions for chrome) We could either have the runtime library report back whether showing the notification was acceptable, or potentially (if it's accessible) chrome could just check whether the destination package has notification permission revoked
,
Sep 12 2017
,
Sep 13 2017
SOrry, wasn't intentional to remove you from cc :/
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e297acb7ca8a3c36b73028eea3352405a27cd3e commit 3e297acb7ca8a3c36b73028eea3352405a27cd3e Author: Ran Ji <ranj@chromium.org> Date: Thu Sep 28 15:12:00 2017 Add WebAPK notification permission status UMA Add a UMA to track whether user has WebAPK display notification permission enabled when a WebAPK receives a notification Bug: 685806 Change-Id: I237947c44b8539e84384312b591be39d3759c4ed Reviewed-on: https://chromium-review.googlesource.com/667002 Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Ran Ji <ranj@chromium.org> Cr-Commit-Position: refs/heads/master@{#505026} [modify] https://crrev.com/3e297acb7ca8a3c36b73028eea3352405a27cd3e/chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java [modify] https://crrev.com/3e297acb7ca8a3c36b73028eea3352405a27cd3e/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkServiceClient.java [modify] https://crrev.com/3e297acb7ca8a3c36b73028eea3352405a27cd3e/chrome/android/webapk/libs/runtime_library/BUILD.gn [modify] https://crrev.com/3e297acb7ca8a3c36b73028eea3352405a27cd3e/chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/IWebApkApi.aidl [add] https://crrev.com/3e297acb7ca8a3c36b73028eea3352405a27cd3e/chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/OWNERS [modify] https://crrev.com/3e297acb7ca8a3c36b73028eea3352405a27cd3e/chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImpl.java [modify] https://crrev.com/3e297acb7ca8a3c36b73028eea3352405a27cd3e/chrome/android/webapk/libs/runtime_library_version.gni [modify] https://crrev.com/3e297acb7ca8a3c36b73028eea3352405a27cd3e/tools/metrics/histograms/enums.xml [modify] https://crrev.com/3e297acb7ca8a3c36b73028eea3352405a27cd3e/tools/metrics/histograms/histograms.xml
,
Sep 28 2017
,
Nov 30 2017
Issue 683292 has been merged into this issue. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sbirch@chromium.org
, Jan 26 2017