New issue
Advanced search Search tips

Issue 685799 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 648686



Sign in to add a comment

Set the HasSeenWin10Promo pref in the right pref store

Project Member Reported by pmonette@chromium.org, Jan 26 2017

Issue description

The pref is registered in local state, but is being set in the profile, which crashes Chrome when the Win10 Welcome page is shown.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c6a615b2b23452b33af668caab3945fe44b52a4

commit 7c6a615b2b23452b33af668caab3945fe44b52a4
Author: pmonette <pmonette@chromium.org>
Date: Fri Jan 27 00:08:01 2017

Set kHasSeenWin10PromoPage in local_state instead of in profile prefs.

The pref is registered to the local state so the old code was incorrect.

BUG= 685799 

Review-Url: https://codereview.chromium.org/2659643003
Cr-Commit-Position: refs/heads/master@{#446497}

[modify] https://crrev.com/7c6a615b2b23452b33af668caab3945fe44b52a4/chrome/browser/ui/webui/welcome_win10_ui.cc

Labels: M-57 Merge-Request-57
Status: Fixed (was: Started)
This is no longer appearing in Canary. Requesting Merge to M57.
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 6 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 6 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d76d75e529b4868ce056abde2ce07bbbd46b2c7e

commit d76d75e529b4868ce056abde2ce07bbbd46b2c7e
Author: Tommy Martino <tmartino@chromium.org>
Date: Mon Feb 06 19:52:07 2017

Set kHasSeenWin10PromoPage in local_state instead of in profile prefs.

The pref is registered to the local state so the old code was incorrect.

BUG= 685799 

Review-Url: https://codereview.chromium.org/2659643003
Cr-Commit-Position: refs/heads/master@{#446497}
(cherry picked from commit 7c6a615b2b23452b33af668caab3945fe44b52a4)

Review-Url: https://codereview.chromium.org/2678013003 .
Cr-Commit-Position: refs/branch-heads/2987@{#342}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/d76d75e529b4868ce056abde2ce07bbbd46b2c7e/chrome/browser/ui/webui/welcome_win10_ui.cc

Sign in to add a comment