New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685794 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocked on:
issue 715782



Sign in to add a comment

Rename Official Linux builders

Project Member Reported by mmoss@chromium.org, Jan 26 2017

Issue description

The Official Linux builders are currently named based on the distro release (Ubuntu Precise) that was used when they were setup, but that designation is obsolete because:

- They are no longer on that same release (Issue 564904 upgraded them to Trusty).

- They have been using a sysroot build environment for a long time, which makes the system distro largely irrelevant, and unlikely that we will ever again need to distinguish between builders running different distros (as was needed during previous uprades, e.g. Lucid -> Precise, where different system libs caused incompatible build output).

The builders should just be renamed s/Precise/Linux/, but since the builder names are also used in the paths of build artifacts (anything else?), downstream consumers, like the signing_pump cron script, and maybe the Omaha push configs, will also need to be updated.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/release/scripts/+/2c7a44c8a88d2c2c9a73d5770dbb4c56f47ad7b6

commit 2c7a44c8a88d2c2c9a73d5770dbb4c56f47ad7b6
Author: Michael Moss <mmoss@google.com>
Date: Thu Apr 13 17:59:17 2017

Comment 2 by mmoss@chromium.org, Apr 22 2017

I doubt we'll want to change this builder name again, but just in case, here are some CLs for internal code that needed to be updated to use the new name/paths:

cl/153894118
cl/153867143
cl/153860904
cl/153860523
cl/153858195

These uses were mostly found by searching for "precise64" in cs/, although that was pretty noisy, and "linux64" will likely be worse (all the more reason to never change it again).

Comment 3 by mmoss@chromium.org, Apr 22 2017

One more:

cl/153872579

Comment 4 by mmoss@chromium.org, Apr 24 2017

cl/154055311
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/release/+/d0593e08b2d3969e0ef6edf3f575d6dbce5fe8f2

commit d0593e08b2d3969e0ef6edf3f575d6dbce5fe8f2
Author: dimu <dimu@google.com>
Date: Tue Apr 25 20:45:23 2017

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/12d24fd028ffe2bfaeda6a8f9aca0d2465f7e477

commit 12d24fd028ffe2bfaeda6a8f9aca0d2465f7e477
Author: dimu <dimu@google.com>
Date: Wed Apr 26 19:45:21 2017

Comment 8 by mmoss@chromium.org, Apr 26 2017

Status: Fixed (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 26 2017

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/3ecf1f20c82c04efd1309167c5106fda308445cd

commit 3ecf1f20c82c04efd1309167c5106fda308445cd
Author: dimu <dimu@google.com>
Date: Wed Apr 26 19:56:41 2017

Comment 11 by mmoss@chromium.org, Apr 26 2017

Blockedon: 715782
Status: Started (was: Fixed)
Reopening because continuous builders hit a snag (Issue 715782).
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 26 2017

Project Member

Comment 13 by bugdroid1@chromium.org, Apr 26 2017

Project Member

Comment 14 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/190ee07cecf53e3795197cc195b844f7cc15a9ea

commit 190ee07cecf53e3795197cc195b844f7cc15a9ea
Author: Michael Moss <mmoss@google.com>
Date: Thu Apr 27 00:46:54 2017

Remove/rename obsolete precise64 official builders.

And update name for the experimental Windows recipe builder.

R=dpranke@chromium.org
TBR=dimu@google.com, dpranke@google.com
BUG=418185, 685794 ,715782

Review-Url: https://codereview.chromium.org/2841253002 .
Cr-Commit-Position: refs/heads/master@{#467534}

[modify] https://crrev.com/190ee07cecf53e3795197cc195b844f7cc15a9ea/tools/mb/mb_config.pyl

Comment 15 by mmoss@chromium.org, Apr 27 2017

Status: Fixed (was: Started)

Sign in to add a comment