New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 685777 link

Starred by 2 users
Status: Fixed
Owner:
█ xlai@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Cc:
danakj@chromium.org
█ staraz@chromium.org
samans@chromium.org
█ fsam...@chromium.org
rjkroege@chromium.org
sadrul@chromium.org
enne@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Refactor and centralize FrameSinkId allocation in one single place

Project Member Reported by xlai@chromium.org, Jan 26 2017 
In a discussion thread in https://codereview.chromium.org/2656893003/, we realize that 
the current allocation of frame_sink_id on different platforms, or even one single platform
with different implementations, are all over the places. 

It would be beneficial for future maintenance if we can centralize all these framesinkid
allocation in one single place. This refactoring effort needs careful planning that involves all platforms.

Comment 1 by xlai@chromium.org, Jan 26 2017

Cc: fsam...@chromium.org xlai@chromium.org

Comment 2 by fsam...@chromium.org, Jan 26 2017

Cc: rjkroege@chromium.org sadrul@chromium.org enne@chromium.org danakj@chromium.org staraz@chromium.org samans@chromium.org
Components: -MUS Internals>Compositing
Labels: displaycompositor

Comment 3 by enne@chromium.org, Jan 31 2017

Status: Available (was: Untriaged)

Comment 4 by xlai@chromium.org, Feb 13 2017

Cc: -xlai@chromium.org
Owner: xlai@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cab2befb20c03d2d91eedf162e92ffe8db80e44f

commit cab2befb20c03d2d91eedf162e92ffe8db80e44f
Author: xlai <xlai@chromium.org>
Date: Wed Feb 22 17:18:03 2017

Centralize FrameSinkId allocation in one place

Currently the allocation of cc::FrameSinkId in render_host_view are scattered
around for different platforms. This CL puts it all in RenderWidgetHostImpl.

In addition, this CL introduced frame_sink_id_allocator so that there will be
no duplicate id generation code in different context factories.

BUG= 685777 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2691363002
Cr-Commit-Position: refs/heads/master@{#452104}

[modify] https://crrev.com/cab2befb20c03d2d91eedf162e92ffe8db80e44f/android_webview/browser/surfaces_instance.cc
[modify] https://crrev.com/cab2befb20c03d2d91eedf162e92ffe8db80e44f/android_webview/browser/surfaces_instance.h
[modify] https://crrev.com/cab2befb20c03d2d91eedf162e92ffe8db80e44f/cc/surfaces/BUILD.gn
[add] https://crrev.com/cab2befb20c03d2d91eedf162e92ffe8db80e44f/cc/surfaces/frame_sink_id_allocator.h
[modify] https://crrev.com/cab2befb20c03d2d91eedf162e92ffe8db80e44f/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/cab2befb20c03d2d91eedf162e92ffe8db80e44f/content/browser/compositor/gpu_process_transport_factory.h
[modify] https://crrev.com/cab2befb20c03d2d91eedf162e92ffe8db80e44f/content/browser/renderer_host/context_provider_factory_impl_android.cc
[modify] https://crrev.com/cab2befb20c03d2d91eedf162e92ffe8db80e44f/content/browser/renderer_host/context_provider_factory_impl_android.h
[modify] https://crrev.com/cab2befb20c03d2d91eedf162e92ffe8db80e44f/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/cab2befb20c03d2d91eedf162e92ffe8db80e44f/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/cab2befb20c03d2d91eedf162e92ffe8db80e44f/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/cab2befb20c03d2d91eedf162e92ffe8db80e44f/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/cab2befb20c03d2d91eedf162e92ffe8db80e44f/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/cab2befb20c03d2d91eedf162e92ffe8db80e44f/ui/compositor/test/in_process_context_factory.cc
[modify] https://crrev.com/cab2befb20c03d2d91eedf162e92ffe8db80e44f/ui/compositor/test/in_process_context_factory.h

Comment 6 by xlai@chromium.org, Feb 23 2017

Status: Fixed (was: Assigned)

Comment 7 by fsam...@chromium.org, Jun 13 2017

Blocking:
►

Sign in to add a comment