New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 685765 link

Starred by 1 user
Status: Fixed
Owner:
samans@chromium.org
Closed: Jan 2017
Cc:
danakj@chromium.org
█ staraz@chromium.org
samans@chromium.org
rjkroege@chromium.org
sadrul@chromium.org
█ mfomitchev@chromium.org
enne@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

LocalFrameId => LocalSurfaceId

Project Member Reported by fsam...@chromium.org, Jan 26 2017 
SurfaceId = (FrameSinkId, LocalFrameId)

LocalFrameId turns out to be a confusing name because it represents a "bucket" of CompositorFrames with a fixed set of properties (size + device scale factor usually). We use the term "surface" for such a bucket.

SurfaceId is a global identifier for that bucket.

Thus, the local identifier within a particular FrameSink or client should probably be called the LocalSurfaceId.

We should thus rename LocalFrameId to LocalSurfaceId.

Comment 1 by danakj@chromium.org, Jan 26 2017

Status: Available (was: Untriaged)

Comment 2 by samans@chromium.org, Jan 27 2017

Owner: samans@chromium.org
Status: Started (was: Available)

Comment 3 by samans@chromium.org, Jan 27 2017 

Yeah, I agree with this. LocalFrameId makes it sound like each frame has its own ID.

Comment 4 by fsam...@chromium.org, Jan 27 2017 

Maybe set is a better word than bucket in my explanation above but hopefully the point was understood :-) Many frames can be submitted to a single surface.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5258bfb4395abf16fca17a6c8fc09ff052eaf845

commit 5258bfb4395abf16fca17a6c8fc09ff052eaf845
Author: samans <samans@chromium.org>
Date: Fri Jan 27 21:16:26 2017

Rename LocalFrameId to LocalSurfaceId

LocalFrameId is a confusing name because it implies it uniquely identifies a
CompositorFrame but in reality multiple frames can be submitted to the same surface
with the same LocalFrameId. LocalFrameId only changes when a new surface is
needed (such as on resize), and therefore we believe LocalSurfaceId would
be a better name for it. So SurfaceId is the global identifier for a surface, and
LocalSurfaceId can be thought of as the local identifier.

TBR=jam@chromium.org
TBR=tsepez@chromium.org

BUG= 685765 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2661543002
Cr-Commit-Position: refs/heads/master@{#446771}

[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/android_webview/browser/hardware_renderer.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/android_webview/browser/hardware_renderer.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/android_webview/browser/surfaces_instance.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/android_webview/browser/surfaces_instance.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/ipc/BUILD.gn
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/ipc/OWNERS
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/ipc/cc_param_traits.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/ipc/cc_param_traits.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/ipc/cc_param_traits_unittest.cc
[delete] https://crrev.com/dc974fef99b96b1a153fa7e7c35949de285c7e67/cc/ipc/local_frame_id.typemap
[delete] https://crrev.com/dc974fef99b96b1a153fa7e7c35949de285c7e67/cc/ipc/local_frame_id_struct_traits.h
[rename] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/ipc/local_surface_id.mojom
[add] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/ipc/local_surface_id.typemap
[add] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/ipc/local_surface_id_struct_traits.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/ipc/mojo_compositor_frame_sink.mojom
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/ipc/struct_traits_unittest.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/ipc/surface_id.mojom
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/ipc/surface_id_struct_traits.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/ipc/typemaps.gni
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/layers/surface_layer_impl_unittest.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/layers/surface_layer_unittest.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/quads/draw_quad_unittest.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/BUILD.gn
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/compositor_frame_sink_support.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/compositor_frame_sink_support.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/direct_compositor_frame_sink.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/direct_compositor_frame_sink.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/display.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/display.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/display_scheduler_unittest.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/display_unittest.cc
[delete] https://crrev.com/dc974fef99b96b1a153fa7e7c35949de285c7e67/cc/surfaces/local_frame_id.cc
[delete] https://crrev.com/dc974fef99b96b1a153fa7e7c35949de285c7e67/cc/surfaces/local_frame_id.h
[add] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/local_surface_id.cc
[add] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/local_surface_id.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/referenced_surface_tracker.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/referenced_surface_tracker.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/referenced_surface_tracker_unittest.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/surface_aggregator.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/surface_aggregator_perftest.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/surface_aggregator_unittest.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/surface_factory.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/surface_factory.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/surface_factory_client.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/surface_factory_unittest.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/surface_hittest_unittest.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/surface_id.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/surface_id.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/surface_id_allocator.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/surface_id_allocator.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/surface_manager.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/surface_manager.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/surface_manager_ref_unittest.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/surface_unittest.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/surfaces/surfaces_pixeltest.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/test/test_compositor_frame_sink.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/cc/test/test_compositor_frame_sink.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/components/display_compositor/gpu_compositor_frame_sink.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/components/display_compositor/gpu_compositor_frame_sink.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/components/exo/compositor_frame_sink.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/components/exo/compositor_frame_sink.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/components/exo/compositor_frame_sink_holder.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/components/exo/surface.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/components/exo/surface.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/content/browser/frame_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/content/browser/frame_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/content/browser/frame_host/render_widget_host_view_guest.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/content/browser/frame_host/render_widget_host_view_guest_unittest.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/content/browser/renderer_host/delegated_frame_host.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/content/browser/renderer_host/offscreen_canvas_surface_impl.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/content/browser/renderer_host/offscreen_canvas_surface_impl.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/content/browser/renderer_host/offscreen_canvas_surface_manager_unittest.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/content/renderer/android/synchronous_compositor_frame_sink.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/content/renderer/android/synchronous_compositor_frame_sink.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/services/ui/public/cpp/window_compositor_frame_sink.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/services/ui/public/cpp/window_compositor_frame_sink.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/services/ui/surfaces/display_compositor.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/services/ui/ws/frame_generator.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/services/ui/ws/frame_generator.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/services/ui/ws/frame_generator_unittest.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/services/ui/ws/window_tree_client_unittest.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/third_party/WebKit/public/blink_typemaps.gni
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/ui/android/delegated_frame_host_android.cc
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/ui/android/delegated_frame_host_android.h
[modify] https://crrev.com/5258bfb4395abf16fca17a6c8fc09ff052eaf845/ui/compositor/layer_unittest.cc

Comment 6 by samans@chromium.org, Jan 28 2017

Status: Fixed (was: Started)

Comment 7 by fsam...@chromium.org, Jun 13 2017

Blocking:
►

Sign in to add a comment