New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 685763 link

Starred by 1 user
Status: Fixed
Owner:
█ roc...@chromium.org
please use my google.com address
Closed: Jan 2017
Cc:
asvitk...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Mojo.System.MessagesAcceptedPerEvent histogram is bad

Project Member Reported by roc...@chromium.org, Jan 26 2017 
As explained to me by asvitkine@, having a huge majority of samples in the 0 bucket makes a histogram significantly less useful, and in this case is also tickling b/33821049.

For this metric we're only interested in cases where the number is abnormally large, so we should just avoid logging samples for small values.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/883e1cd758c53676c99f61b5fc75ae11b1a0a1fb

commit 883e1cd758c53676c99f61b5fc75ae11b1a0a1fb
Author: rockot <rockot@chromium.org>
Date: Thu Jan 26 23:15:12 2017

Avoid logging very small values for Mojo.System.MessagesAcceptedPerEvent

BUG= 685763 
R=asvitkine@chromium.org

Review-Url: https://codereview.chromium.org/2649233010
Cr-Commit-Position: refs/heads/master@{#446488}

[modify] https://crrev.com/883e1cd758c53676c99f61b5fc75ae11b1a0a1fb/mojo/edk/system/node_controller.cc
[modify] https://crrev.com/883e1cd758c53676c99f61b5fc75ae11b1a0a1fb/tools/metrics/histograms/histograms.xml

Comment 2 by roc...@chromium.org, Jan 26 2017

Status: Fixed (was: Started)
►

Sign in to add a comment