New issue
Advanced search Search tips

Issue 685756 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Rename WebUSB Origin Trial for Chrome 57-59

Project Member Reported by reillyg@chromium.org, Jan 26 2017

Issue description

The WebUSB Origin Trial will be continuing in Chrome 57 through 59 however in order to ensure that keys issued for the previous trial are not valid for the new trial the origin_trial_feature_name must be changed from "WebUSB" to "WebUSB2".

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb07160473f518862e5a8b5d3791266be5e5a91b

commit fb07160473f518862e5a8b5d3791266be5e5a91b
Author: reillyg <reillyg@chromium.org>
Date: Sat Jan 28 00:40:37 2017

Rename the WebUSB Origin Trial to "WebUSB2".

This rename has no effect on any of the feature flags but will require
that new Origin Trial keys for the feature be issued for "WebUSB2". This
ensures a clean break between the original trial period (Chrome 54-56)
and the new trial period (Chrome 57-59).

BUG= 685756 

Review-Url: https://codereview.chromium.org/2657443008
Cr-Commit-Position: refs/heads/master@{#446854}

[modify] https://crrev.com/fb07160473f518862e5a8b5d3791266be5e5a91b/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Labels: Merge-Request-57
Status: Fixed (was: Started)
This needs to be merged into M-57 or else we will continue accepting the old origin trial keys (until they expire).
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 30 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by gov...@chromium.org, Jan 30 2017

Please merge  your change to M57 branch 2987 ASAP.If merge happens today before 5:00 PM PT, then we can take it for tomorrow's last M57 Dev release. Thank you.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 30 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0058e87a7edbff543e06aeadf84c358265b280d6

commit 0058e87a7edbff543e06aeadf84c358265b280d6
Author: Reilly Grant <reillyg@chromium.org>
Date: Mon Jan 30 19:53:38 2017

Rename the WebUSB Origin Trial to "WebUSB2".

This rename has no effect on any of the feature flags but will require
that new Origin Trial keys for the feature be issued for "WebUSB2". This
ensures a clean break between the original trial period (Chrome 54-56)
and the new trial period (Chrome 57-59).

BUG= 685756 

Review-Url: https://codereview.chromium.org/2657443008
Cr-Commit-Position: refs/heads/master@{#446854}
(cherry picked from commit fb07160473f518862e5a8b5d3791266be5e5a91b)

Review-Url: https://codereview.chromium.org/2660973002 .
Cr-Commit-Position: refs/branch-heads/2987@{#175}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/0058e87a7edbff543e06aeadf84c358265b280d6/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Sign in to add a comment