New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 685739 link

Starred by 1 user
Status: Fixed
Owner:
█ aval...@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Cc:
dmazz...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 655753



Sign in to add a comment

OOPIF: <webview> content not in accessibility tree

Project Member Reported by aval...@chromium.org, Jan 26 2017 
Run chrome with --enable-features=GuestViewCrossProcessFrames

Intall https://chrome.google.com/webstore/detail/browser-sample/edggnmnajhcbhlnpjnogkjpghaikidaa.

open chrome://accessibility and look at the ax tree for the browser (both the extension AND guest (google.com) need to have accessibility turned on to work correctly. In the --enable-features=GuestViewCrossProcessFrames mode, the parent will not display the guest tree. with the feature disabled, it does.

OOPIFs on the other hand only show 1 item on chrome://accessibility.


dmazzoni: any tips on getting this fixed would be great.

Comment 1 by aval...@chromium.org, Feb 21 2017

Owner: aval...@chromium.org
Status: Started (was: Untriaged)
Should be fixed by pending change https://codereview.chromium.org/2674353003/
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d68cdd1afdff55d24558ef88441d9ac950d46dd4

commit d68cdd1afdff55d24558ef88441d9ac950d46dd4
Author: avallee <avallee@chromium.org>
Date: Wed Jun 21 22:07:27 2017

Enable WebViewAccessiblityTest for OOPIF webview.

+ Enabled WebViewAccessibilityTests for oopif.
+ Hooked up the inner AX tree to point back to the AX tree for the outer web
  contents. Otherwise BrowserAccessibility::Platform{ChildCount,GetChild}
  functions fail on the [child->GetParent() == this] check.

BUG= 610795 ,  685739 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2674353003
Cr-Commit-Position: refs/heads/master@{#481326}

[modify] https://crrev.com/d68cdd1afdff55d24558ef88441d9ac950d46dd4/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/d68cdd1afdff55d24558ef88441d9ac950d46dd4/content/browser/frame_host/render_frame_host_delegate.cc
[modify] https://crrev.com/d68cdd1afdff55d24558ef88441d9ac950d46dd4/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/d68cdd1afdff55d24558ef88441d9ac950d46dd4/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/d68cdd1afdff55d24558ef88441d9ac950d46dd4/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/d68cdd1afdff55d24558ef88441d9ac950d46dd4/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/d68cdd1afdff55d24558ef88441d9ac950d46dd4/content/renderer/render_frame_impl.cc

Comment 3 by aval...@chromium.org, Jun 21 2017

Status: Fixed (was: Started)

Comment 4 by aval...@chromium.org, Jun 22 2017

Blocking: 655753
Had not been added as blocking but it is fixed now.
►

Sign in to add a comment