New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685727 link

Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature


Show other hotlists

Hotlists containing this issue:
Deprecations


Sign in to add a comment

Deprecate RTCRtcpMuxPolicy of "negotiate"

Project Member Reported by deadbeef@chromium.org, Jan 26 2017

Issue description

In M57, we changed the default policy to "require". The next step is to deprecate "negotiate", by providing a deprecation message and adding a use counter in M58. Then, in a later release, we may be able to remove it completely.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/887a0d5ac980c21eebecb133a75e08dc2fe048bf

commit 887a0d5ac980c21eebecb133a75e08dc2fe048bf
Author: zhihuang <zhihuang@chromium.org>
Date: Fri Feb 17 01:06:39 2017

Add a use counter for RtcpMuxPolicy of "negotiate".

When parsing the RTCConfiguration, if the RtcpMuxPolicy is "negotiate",
it will be counted. The number will be used to estimate the risk of
removing this feature.

Intent to deprecate thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/OP2SGSWF5lo

BUG= chromium:685727 

Review-Url: https://codereview.chromium.org/2679093006
Cr-Commit-Position: refs/heads/master@{#451162}

[modify] https://crrev.com/887a0d5ac980c21eebecb133a75e08dc2fe048bf/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/887a0d5ac980c21eebecb133a75e08dc2fe048bf/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/887a0d5ac980c21eebecb133a75e08dc2fe048bf/tools/metrics/histograms/histograms.xml

Labels: -WebRTCTriaged -M-58 Merge-Request-57
Labels: -Type-Bug Type-Feature
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 27 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-57 Merge-Request-57
Project Member

Comment 7 by sheriffbot@chromium.org, Mar 1 2017

Labels: -Merge-Request-57 Hotlist-Merge-Review Merge-Review-57
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Pls apply appropriate OS labels. Thank you. 
Cc: zhihuang@chromium.org
zhihuang@, we're VERY close to M57 stable launch and this is Type:Feature and not a bug, can this wait until M58? Also please apply appropriate OS labels. Thank you. 


Labels: OS-All
Since we have already changed the default value of the rtcpMuxPolicy from "negotiate" to "require" in M57, it would be better to notify the users that we are actually considering the removal of rtcpMuxPolicy option at the same time.

This is the intend to deprecate thread:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/OP2SGSWF5lo

It would be great if this can be merged but it is also fine to wait until M58.
Thank you zhihuang@. Is change listed at #5 bake/verified in Canary, having enough automation coverage and will be a safe merge to M57?

Comment 12 Deleted

This CL is already in Canary build. and it shouldn't be risky to merge as this CL only adds a deprecation message to the console.

Comment 14 Deleted

Approving merge for cl listed #5 to M57 branch 2987 based on comment #10 and #13. Thank you.
If possible, could you please merge your change to M57 branch 2987 by 5:00 PM PT tomorrow, Thursday (03/02).
Thank you.
I'm not a full committer to Chromium and I cannot land the merge directly.
It automatically generated a C(https://codereview.chromium.org/2727783002/) which needs to be approved by a full committer. I'll submit it once it is LGTMed.
Isn'it too aggressive to deprecate in M57? The usage statistics were introduced recently. I think those statistics should be investigated first after M57 becones stable. This is when the actual usage of negotiate can be observed.
And if you dovthe deprecation so quickly, it means the removal can happen in a short timeframe and those who don't support rtcp muxing will not have enough time to start supporting it. This is a serious problen for webrtc based sokution vendors. This will cause outages. Such an important change should be done more carefully.

Also, release notes for M57 is recently published: https://groups.google.com/forum/#!topic/discuss-webrtc/xXjeKbW_JYI

I don't think you can make such a "deprecation" change at this time. Please deliver your deprecation change to M58 or later.
The motivation of this change is notifying the user that we are actually considering to remove the rtcpMuxPolicy option. This change will not break anything but just showing a deprecation message when users try to use it and the option will not be removed before M60, around August 2017. 

Please see https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/OP2SGSWF5lo for more detailed discussion.
Please merge your change to M57 branch 2987 latest by 5:00 PM PT Friday, 03/03 (sooner the better) so we can take it in for M57 Desktop Stable cut. Thank you.
Project Member

Comment 22 by bugdroid1@chromium.org, Mar 3 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43cca2fb095873d29c99b19947c6dc867fa0c884

commit 43cca2fb095873d29c99b19947c6dc867fa0c884
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Fri Mar 03 15:24:00 2017

Add a use counter for RtcpMuxPolicy of "negotiate".

When parsing the RTCConfiguration, if the RtcpMuxPolicy is "negotiate",
it will be counted. The number will be used to estimate the risk of
removing this feature.

Intent to deprecate thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/OP2SGSWF5lo

BUG= chromium:685727 

Review-Url: https://codereview.chromium.org/2679093006
Cr-Commit-Position: refs/heads/master@{#451162}
(cherry picked from commit 887a0d5ac980c21eebecb133a75e08dc2fe048bf)

Review-Url: https://codereview.chromium.org/2733583002 .
Cr-Commit-Position: refs/branch-heads/2987@{#749}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/43cca2fb095873d29c99b19947c6dc867fa0c884/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/43cca2fb095873d29c99b19947c6dc867fa0c884/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/43cca2fb095873d29c99b19947c6dc867fa0c884/tools/metrics/histograms/histograms.xml

Project Member

Comment 23 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f820422f2b7196ef6c410558b4fdc50ad7f613ad

commit f820422f2b7196ef6c410558b4fdc50ad7f613ad
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Fri Mar 03 15:27:23 2017

Add a deprecation message to rtcpMuxPolicy of negotiate.

When parsing the RTCConfiguration, if the RtcpMuxPolicy is explicitly set
to be "negotiate", the deprecation message will be return to the console.

If this is approved, the change will be merged to M57.

BUG= chromium:685727 

Review-Url: https://codereview.chromium.org/2720763004
Cr-Commit-Position: refs/heads/master@{#453771}
(cherry picked from commit 918bb2c91f07a2cce51cea68554bd56566dec0dc)

Review-Url: https://codereview.chromium.org/2725293004 .
Cr-Commit-Position: refs/branch-heads/2987@{#750}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/f820422f2b7196ef6c410558b4fdc50ad7f613ad/third_party/WebKit/LayoutTests/external/wpt/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt
[modify] https://crrev.com/f820422f2b7196ef6c410558b4fdc50ad7f613ad/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-expected.txt
[modify] https://crrev.com/f820422f2b7196ef6c410558b4fdc50ad7f613ad/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/f820422f2b7196ef6c410558b4fdc50ad7f613ad/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

Project Member

Comment 24 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e74e7b8d22158d8f6b0a3c835df6e22290e1457e

commit e74e7b8d22158d8f6b0a3c835df6e22290e1457e
Author: foolip <foolip@chromium.org>
Date: Fri Mar 03 17:24:06 2017

Fix compile failure in Deprecation.cpp (missing M60 enum value)

BUG= 685727 
TBR=zhihuang@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2725353002
Cr-Commit-Position: refs/branch-heads/2987@{#752}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/e74e7b8d22158d8f6b0a3c835df6e22290e1457e/third_party/WebKit/Source/core/frame/Deprecation.cpp

Status: Fixed (was: Available)
Project Member

Comment 26 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c12d093e94c924034f682abe7e7f643453fd28c

commit 0c12d093e94c924034f682abe7e7f643453fd28c
Author: deadbeef <deadbeef@chromium.org>
Date: Thu Apr 20 22:23:18 2017

Pushing back rtcpMuxPolicy deprecation message to M62.

Since originally adding this deprecation message, we heard from the
Asterisk community (which would be affected by this change), and believe
that M62 will give enough time for users who use "modern branches" of
Asterisk to upgrade to a new version that supports RTCP muxing.

See discussion here:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/OP2SGSWF5lo/v7GOaWt_CQAJ

BUG= chromium:685727 

Review-Url: https://codereview.chromium.org/2826123003
Cr-Commit-Position: refs/heads/master@{#466163}

[modify] https://crrev.com/0c12d093e94c924034f682abe7e7f643453fd28c/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-expected.txt
[modify] https://crrev.com/0c12d093e94c924034f682abe7e7f643453fd28c/third_party/WebKit/Source/core/frame/Deprecation.cpp

Removing this option would break compatibility between Chrome and any SIP client that does not support RTCP mux. It would significantly reduce interoperability, just like forcing DTLS encryption once did. I fail to see the point of removing an existing useful feature.


Comment 28 by ibc@aliax.net, May 22 2018

> Removing this option would break compatibility between Chrome and any SIP client that does not support RTCP mux. It would significantly reduce interoperability, just like forcing DTLS encryption once did. I fail to see the point of removing an existing useful feature.

Welcome to WebRTC. If the media layer can be simplified then it must be simplified. Keeping diverse options just for compatibility with legacy devices should not be the target of WebRTC.
[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable?

Sign in to add a comment