New issue
Advanced search Search tips

Issue 685725 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

[scroll anchoring] no adjustment on politico.com

Project Member Reported by skobes@chromium.org, Jan 26 2017

Issue description

Reproduced on desktop Linux ToT.

1. Visit http://www.politico.com/story/2017/01/democrats-trump-strategy-234206
2. While the page is loading, scroll down until the giant image overlaps the top of the viewport
3. Observe two jumps

ScrollAnchor should be anchoring to the image and performing adjustments, but it isn't.

Initial investigation suggests it is not a SANACLAP suppression, but findAnchor may be getting confused by some of the floats in the header.
 

Comment 1 by skobes@chromium.org, Jan 26 2017

We are computing incorrect bounds for the .nav-micro element due to the .subnav-content descendants styled with "top: -999em".  Patch up: http://crrev.com/2662443003
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bcdced388956bfc8c137cfd20c830d30748946d

commit 9bcdced388956bfc8c137cfd20c830d30748946d
Author: skobes <skobes@chromium.org>
Date: Thu Jan 26 23:07:53 2017

Fix treatment of layout overflow rect in ScrollAnchor bounds computation.

The relativeBounds helper assumed the anchor candidate's layout overflow rect
was positioned at 0,0 in its local coordinate space, but this is not always the
case, e.g. if positioned children have negative offsets.

BUG= 685725 

Review-Url: https://codereview.chromium.org/2662443003
Cr-Commit-Position: refs/heads/master@{#446485}

[modify] https://crrev.com/9bcdced388956bfc8c137cfd20c830d30748946d/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp
[modify] https://crrev.com/9bcdced388956bfc8c137cfd20c830d30748946d/third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp

Comment 3 by skobes@chromium.org, Jan 27 2017

Status: Fixed (was: Started)
Verified in canary (58.0.2994.1).

Sign in to add a comment