Answers in Suggest in Views are too small |
||||||
Issue descriptionCompare the attached screenshots for an example weather answer.
,
Feb 2 2017
,
Feb 3 2017
Verified in Windows Canary (58.0.3001.0).
,
Feb 3 2017
,
Feb 3 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 3 2017
Please merge your change to M57 branch 2987 before 5:00 PM Pt, Monday (02/06/) so we can pick it up for next week Beta release. Thank you.
,
Feb 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/738b5637aa3218e44f5a29ea9412a69efc26e2a3 commit 738b5637aa3218e44f5a29ea9412a69efc26e2a3 Author: Justin Donnelly <jdonnelly@chromium.org> Date: Mon Feb 06 18:11:26 2017 Fix the size of omnibox suggestion answers. Through a confluence of various changes, OmniboxResultView got into a state where the height given to answers is always the largest size but the actual font used is the regular font size. This fix ensures that both the size of the font and the space it's given are driven by the data in the answer. For the currently launched answers, this is always the largest size so they're being shown too small. But this fix will also support upcoming answer types that don't use the largest font size. BUG= 685714 Review-Url: https://codereview.chromium.org/2654163005 Cr-Commit-Position: refs/heads/master@{#447702} (cherry picked from commit 5fdae6fa2582b407ad6281c152e5cb6f7b95a391) Review-Url: https://codereview.chromium.org/2671323003 . Cr-Commit-Position: refs/branch-heads/2987@{#334} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/738b5637aa3218e44f5a29ea9412a69efc26e2a3/chrome/browser/ui/views/omnibox/omnibox_result_view.cc [modify] https://crrev.com/738b5637aa3218e44f5a29ea9412a69efc26e2a3/chrome/browser/ui/views/omnibox/omnibox_result_view.h |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Feb 2 2017