New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685714 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Answers in Suggest in Views are too small

Project Member Reported by jdonnelly@chromium.org, Jan 26 2017

Issue description

Compare the attached screenshots for an example weather answer.
 
IMG_20170125_112508.jpg
4.1 MB View Download
Screenshot from 2017-01-26 10:45:33.png
32.9 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fdae6fa2582b407ad6281c152e5cb6f7b95a391

commit 5fdae6fa2582b407ad6281c152e5cb6f7b95a391
Author: jdonnelly <jdonnelly@chromium.org>
Date: Thu Feb 02 05:49:37 2017

Fix the size of omnibox suggestion answers.

Through a confluence of various changes, OmniboxResultView got into a state where the height given to answers is always the largest size but the actual font used is the regular font size.

This fix ensures that both the size of the font and the space it's given are driven by the data in the answer. For the currently launched answers, this is always the largest size so they're being shown too small. But this fix will also support upcoming answer types that don't use the largest font size.

BUG= 685714 

Review-Url: https://codereview.chromium.org/2654163005
Cr-Commit-Position: refs/heads/master@{#447702}

[modify] https://crrev.com/5fdae6fa2582b407ad6281c152e5cb6f7b95a391/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
[modify] https://crrev.com/5fdae6fa2582b407ad6281c152e5cb6f7b95a391/chrome/browser/ui/views/omnibox/omnibox_result_view.h

Labels: OS-Mac
Status: Fixed (was: Started)
Labels: Merge-Request-57
Status: Verified (was: Fixed)
Verified in Windows Canary (58.0.3001.0).
Labels: -OS-Mac
Project Member

Comment 5 by sheriffbot@chromium.org, Feb 3 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please merge your change to M57 branch 2987 before 5:00 PM Pt, Monday (02/06/) so we can pick it up for next week Beta release. Thank you.
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 6 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/738b5637aa3218e44f5a29ea9412a69efc26e2a3

commit 738b5637aa3218e44f5a29ea9412a69efc26e2a3
Author: Justin Donnelly <jdonnelly@chromium.org>
Date: Mon Feb 06 18:11:26 2017

Fix the size of omnibox suggestion answers.

Through a confluence of various changes, OmniboxResultView got into a state where the height given to answers is always the largest size but the actual font used is the regular font size.

This fix ensures that both the size of the font and the space it's given are driven by the data in the answer. For the currently launched answers, this is always the largest size so they're being shown too small. But this fix will also support upcoming answer types that don't use the largest font size.

BUG= 685714 

Review-Url: https://codereview.chromium.org/2654163005
Cr-Commit-Position: refs/heads/master@{#447702}
(cherry picked from commit 5fdae6fa2582b407ad6281c152e5cb6f7b95a391)

Review-Url: https://codereview.chromium.org/2671323003 .
Cr-Commit-Position: refs/branch-heads/2987@{#334}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/738b5637aa3218e44f5a29ea9412a69efc26e2a3/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
[modify] https://crrev.com/738b5637aa3218e44f5a29ea9412a69efc26e2a3/chrome/browser/ui/views/omnibox/omnibox_result_view.h

Sign in to add a comment