WASM module deserialization can throw exception despite TryCatch |
|||
Issue descriptionBlink catches all deserialization failures and produces 'null' (i.e., the 'data' getter on MessageEvent cannot throw, etc.). WASM is currently getting past this, because it's scheduling an exception but it isn't promoted, so it escapes the TryCatch in V8ScriptValueDeserializer and gets thrown by the runtime later on. It should promote the exception like everything else does. This will require changing a layout test which currently expects the exception.
,
Jan 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c972f1886fe4ea5a7fa8e467a499aeae2a315db9 commit c972f1886fe4ea5a7fa8e467a499aeae2a315db9 Author: jbroman <jbroman@chromium.org> Date: Thu Jan 26 21:56:23 2017 Mark wasm_serialization_tests.html as possibly failing while a V8-side change lands. BUG= 685713 Review-Url: https://codereview.chromium.org/2657873005 Cr-Commit-Position: refs/heads/master@{#446464} [modify] https://crrev.com/c972f1886fe4ea5a7fa8e467a499aeae2a315db9/third_party/WebKit/LayoutTests/TestExpectations
,
Jan 27 2017
,
Jan 27 2017
https://codereview.chromium.org/2659483004 also landed on the V8 side (but I forgot the chromium: prefix, so bugdroid didn't comment).
,
Jan 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4dba869a3d98fa911eaba9381e84aaca69057a5 commit e4dba869a3d98fa911eaba9381e84aaca69057a5 Author: jbroman <jbroman@chromium.org> Date: Fri Jan 27 19:24:53 2017 Adjust wasm_serialization_tests.html the layout test to expect null on failure. BUG= 685713 Review-Url: https://codereview.chromium.org/2655403003 Cr-Commit-Position: refs/heads/master@{#446733} [modify] https://crrev.com/e4dba869a3d98fa911eaba9381e84aaca69057a5/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/e4dba869a3d98fa911eaba9381e84aaca69057a5/third_party/WebKit/LayoutTests/http/tests/wasm/wasm_serialization_tests.js
,
Jan 27 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by jbroman@chromium.org
, Jan 26 2017