New issue
Advanced search Search tips

Issue 685702 link

Starred by 1 user
Status: Fixed
Owner:
alito@chromium.org
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Feature



Sign in to add a comment

Deduplicate some initialization code in tests between ProfileResetter and SettingsResetPromptModel

Project Member Reported by alito@chromium.org, Jan 26 2017 
The unittests for the ProfileResetter and SettingsResetPromptModel share some initialization code for creating a TemplateUrlService for the tests. See if this can be refactored into a common function to be used in both tests.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e44ea3b37eab57ca6ff563802454af6e35a8331e

commit e44ea3b37eab57ca6ff563802454af6e35a8331e
Author: Ali Tofigh <alito@chromium.org>
Date: Tue Nov 07 21:43:39 2017

Deduplicate some test code

The unit tests for profile_resetter and settings_reset_prompt_model
need a TemplateURLService. This CL moves the helper function for
creating a TemplateURLService to profile_resetter_test_base where it
can be used by both classes.

Bug:  685702 
Change-Id: I06df5b2ff73e9bde1ca6357b68701c7e7ae1f007
Reviewed-on: https://chromium-review.googlesource.com/755802
Reviewed-by: Chris Sharp <csharp@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Ali Tofigh <alito@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514609}
[modify] https://crrev.com/e44ea3b37eab57ca6ff563802454af6e35a8331e/chrome/browser/profile_resetter/profile_resetter_test_base.cc
[modify] https://crrev.com/e44ea3b37eab57ca6ff563802454af6e35a8331e/chrome/browser/profile_resetter/profile_resetter_test_base.h
[modify] https://crrev.com/e44ea3b37eab57ca6ff563802454af6e35a8331e/chrome/browser/profile_resetter/profile_resetter_unittest.cc
[modify] https://crrev.com/e44ea3b37eab57ca6ff563802454af6e35a8331e/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_model_unittest.cc

Comment 2 by alito@chromium.org, Nov 7 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment