New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 685695 link

Starred by 1 user
Status: Duplicate
Merged: issue 645511
Owner: ----
Closed: Jan 2017
Cc:
danakj@chromium.org
lukasza@chromium.org
dcheng@chromium.org
█ nasko@chromium.org
lfg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 578344



Sign in to add a comment

Unneeded declaration of DOMWrapperWorld::RegisterDOMObjectHolder

Project Member Reported by lukasza@chromium.org, Jan 26 2017 
There is one declaration of DOMWrapperWorld::RegisterDOMObjectHolder that doesn't get rewritten.  It seems that this declaration can be safely removed without impacting ability to compile (at least "on my machine").  Let's try to remove this declaration.

Comment 1 by lukasza@chromium.org, Jan 26 2017 

../../third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp:298:32: error: explicit instantiation of 'registerDOMObjectHolder' does not refer to a function template, variable template, member function, member class, or static data member
template void DOMWrapperWorld::registerDOMObjectHolder(v8::Isolate*,

Comment 2 by lukasza@chromium.org, Jan 26 2017

Cc: lukasza@chromium.org
Owner: ----
Status: Available (was: Started)
Hmmm... actually compilation succeeds with the removed decl, but linking doesn't... :-(

./libblink_core.so: error: undefined reference to 'void blink::DOMWrapperWorld::registerDOMObjectHolder<blink::ScriptFunction>(v8::Isolate*, blink::ScriptFunction*, v8::Local<v8::Value>)'

Maybe we can just fix this manually, when/before landing the big rename... :-/

Comment 3 by dtapu...@chromium.org, Jan 27 2017

Components: Blink>Bindings

Comment 4 by lukasza@chromium.org, Jan 27 2017

Mergedinto: 645511
Status: Duplicate (was: Available)
►

Sign in to add a comment