New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685692 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 15 days ago
Closed: Feb 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Context menu for LoFi-replaced images isn't shown in Chrome Custom Tabs

Project Member Reported by bbergher@chromium.org, Jan 26 2017

Issue description

Device name: Nexus 6P
Application version: Canary 58.0.2992.0
Operating system: Android 7.1.1; Nexus 6P/Build N4F26J
Flags: #data-reduction-proxy-lo-fi set to "Always on", assuming this happens with 'Enabled' in slow connections

Steps to reproduce:
(1) Open an app which uses Chrome Custom Tabs (I used Reddit)
(2) Click on a link to a page with images
(3) Find an image which has been replaced by LoFi
(4) Long press on the image

Example URLs:
Post on the Reddit App
https://www.reddit.com/r/news/comments/5q5615/trump_orders_wall_to_be_built_on_mexico_border/
Target URL
http://www.bbc.com/news/world-us-canada-38740717

Expected result:
Context menu should be shown, so I can load the replaced image.

Actual result:
The long press gesture is detected (image is highlighted, phone vibrates) but no context menu is shown. It is shown for linked images, but only showing Link options (no Image options).

 

Comment 1 by bengr@chromium.org, Feb 9 2017

Labels: -Pri-3 M-58 Pri-2
Owner: megjab...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/561f3eacf7cc29fb1d8fe7d74b76fec1ec7ea7c8

commit 561f3eacf7cc29fb1d8fe7d74b76fec1ec7ea7c8
Author: megjablon <megjablon@chromium.org>
Date: Tue Feb 14 03:43:41 2017

Load original image should be allowed on all context menus

BUG= 685692 

Review-Url: https://codereview.chromium.org/2689643002
Cr-Commit-Position: refs/heads/master@{#450224}

[modify] https://crrev.com/561f3eacf7cc29fb1d8fe7d74b76fec1ec7ea7c8/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

Status: Fixed (was: Assigned)

Sign in to add a comment