New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 685688 link

Starred by 1 user
Status: Fixed
Owner:
lukasza@chromium.org
Closed: Jan 2017
Cc:
danakj@chromium.org
dcheng@chromium.org
█ nasko@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 578344



Sign in to add a comment

Need to remove duplicated EXPECT_POINT_EQ macro definition

Project Member Reported by lukasza@chromium.org, Jan 26 2017 
There is an identical definition of EXPECT_POINT_EQ macro in third_party/WebKit/Source/web/tests/VisualViewportTest.cpp - one on line 56 and one on line 68.

Well, rewrite_to_chrome_style renames (expected).x() to (expected).X() in one of the macro definitions, but not the other.

Let's just delete the other one.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee915a77341510d15c397dce5094a826fe369e38

commit ee915a77341510d15c397dce5094a826fe369e38
Author: lukasza <lukasza@chromium.org>
Date: Thu Jan 26 19:41:31 2017

Delete duplicate macro definition of EXPECT_POINT_EQ.

BUG= 685688 

Review-Url: https://codereview.chromium.org/2651383002
Cr-Commit-Position: refs/heads/master@{#446399}

[modify] https://crrev.com/ee915a77341510d15c397dce5094a826fe369e38/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

Comment 2 by lukasza@chromium.org, Jan 26 2017

Status: Fixed (was: Started)
►

Sign in to add a comment