Editable fields include -

1. Printer Name
2. Address
3. Protocol
4. Queue
5. Associated PPD file

The Printer Model and URI fields are not editable.

We should follow the MD settings guidelines which open a dialog for editing rather than a sub-pager for Details.

Weifang, I have two questions for this issue:
1. How do we want to edit associated PPD file?
2. After these fields are modified, are we going to attempt to re-configure the printer? If so, what will happen if the configuration fails?

Hi Daisy,

For (1) - The user should be able to specify a printer manufacturer/model or upload a PPD file similar to the initial setup. Are we able to condense the window for this is in a modify screen w/ scroll?

For (2) - I assume yes. If the configuration fails, we should report the error using MD settings guidelines in the edit window.

Consolidated dialog with a scroll mock. 

Deleted: Screen Shot 2017-06-23 at 2.45.53 PM.png 58.9 KB

	Screen Shot 2017-06-23 at 2.45.53 PM.png 58.9 KB View Download

Weifang: could you check if the dialog in #6 is up-to-date?

There's some additional information that printers contain that's not editable in the current setup dialogs.  In addition to a user providing a PPD, the printer can also be set to 'autoconfigure' where we try to detect the configuration when you try to use it.  Right now, we do this automatically in the dialog.  However, we'll need a button or a checkbox to represent this choice.  Also, this is exclusive to the other PPD options.

skau@ - For my understanding, for printers which are eligible for autoconfigure on initial setup, this is an attribute which persists with the printer? I had thought that once a printer was setup, the Edit capability would just allow a general override?

We can disallow the transition manual -> autoconfigure but still need a way to represent that a printer is autoconfigured in the UI.  In this case, 'autoconfigured' means that we don't need a PPD for that device.  Even if you can't edit it.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4593cc4454079163607dd12e0453f2f6f4aeacfb

commit 4593cc4454079163607dd12e0453f2f6f4aeacfb
Author: xdai <xdai@chromium.org>
Date: Fri Jul 28 16:24:47 2017

[CUPS] Add strings for Edit-Printer-Dialog first.

Since the cut data to merge strings is 7/28, add strings that are used in
https://chromium-review.googlesource.com/c/582271/ first to catch the
string merge deadline.

Bug:  685673 
Change-Id: I8a8d0be9c56dc0780a5f47b861d0360a702c631f
Reviewed-on: https://chromium-review.googlesource.com/590307
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490422}
[modify] https://crrev.com/4593cc4454079163607dd12e0453f2f6f4aeacfb/chrome/app/settings_strings.grdp
[modify] https://crrev.com/4593cc4454079163607dd12e0453f2f6f4aeacfb/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d00d9c2de5260c886da3746db6952e80e505a4b6

commit d00d9c2de5260c886da3746db6952e80e505a4b6
Author: xdai <xdai@chromium.org>
Date: Fri Jul 28 21:27:24 2017

[Merge to M61][CUPS] Add strings for Edit-Printer-Dialog first.

Since the cut data to merge strings is 7/28, add strings that are used in
https://chromium-review.googlesource.com/c/582271/ first to catch the
string merge deadline.

TBR=michaelpg@chromium.org
(cherry picked from commit 4593cc4454079163607dd12e0453f2f6f4aeacfb)

Bug:  685673 
Change-Id: I8a8d0be9c56dc0780a5f47b861d0360a702c631f
Reviewed-on: https://chromium-review.googlesource.com/590307
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490422}
Reviewed-on: https://chromium-review.googlesource.com/592448
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#115}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/d00d9c2de5260c886da3746db6952e80e505a4b6/chrome/app/settings_strings.grdp
[modify] https://crrev.com/d00d9c2de5260c886da3746db6952e80e505a4b6/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Only strings was merged in #14 so remove "merge-merged-3163" label.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f57a92464231ba64c0dd18d014d4a96c6e12873

commit 7f57a92464231ba64c0dd18d014d4a96c6e12873
Author: Sean Kau <skau@chromium.org>
Date: Tue Aug 01 19:00:26 2017

Implement a reverse lookup for printer make and model.

We need to generate a make and model string from a PpdReference for edit
to behave reasonably.  So, lookup make and model from our PPD index.
Because we don't want to assume anything about the relationship of the
effective_make_and_model strings and manufacturer names, iterate through
all of them.

Bug:  685673 
Change-Id: I016e2cbc45abc9ee6e8a6edf556a962c07c94541
Reviewed-on: https://chromium-review.googlesource.com/592767
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491068}
[modify] https://crrev.com/7f57a92464231ba64c0dd18d014d4a96c6e12873/chromeos/printing/ppd_provider.cc
[modify] https://crrev.com/7f57a92464231ba64c0dd18d014d4a96c6e12873/chromeos/printing/ppd_provider.h
[modify] https://crrev.com/7f57a92464231ba64c0dd18d014d4a96c6e12873/chromeos/printing/ppd_provider_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d20a9e9743a868b37801b6d3fcf61a5d5a6c0da4

commit d20a9e9743a868b37801b6d3fcf61a5d5a6c0da4
Author: xdai <xdai@chromium.org>
Date: Fri Aug 04 23:56:30 2017

[CUPS] Add the ability to edit a printer's setup

Currently, if a printer is setup incorrectly on initial configuration,
there is no way to correct for this except to remove the printer and add
it as new. We should add the ability to Edit the printer setup.

This CL removed the old CUPS printer details page and replaced it with
the Edit Printer dialog.

Bug:  685673 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3115bcd9a68ea1e2ce6ad49b3db787bcc0ec13d3
Reviewed-on: https://chromium-review.googlesource.com/582271
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492181}
[modify] https://crrev.com/d20a9e9743a868b37801b6d3fcf61a5d5a6c0da4/chrome/browser/resources/settings/printing_page/compiled_resources2.gyp
[modify] https://crrev.com/d20a9e9743a868b37801b6d3fcf61a5d5a6c0da4/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
[modify] https://crrev.com/d20a9e9743a868b37801b6d3fcf61a5d5a6c0da4/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js
[modify] https://crrev.com/d20a9e9743a868b37801b6d3fcf61a5d5a6c0da4/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
[modify] https://crrev.com/d20a9e9743a868b37801b6d3fcf61a5d5a6c0da4/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.js
[add] https://crrev.com/d20a9e9743a868b37801b6d3fcf61a5d5a6c0da4/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.html
[add] https://crrev.com/d20a9e9743a868b37801b6d3fcf61a5d5a6c0da4/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.js
[delete] https://crrev.com/22d5203ed1c087f47834df8aa68acab89932a83c/chrome/browser/resources/settings/printing_page/cups_printer_details_page.html
[delete] https://crrev.com/22d5203ed1c087f47834df8aa68acab89932a83c/chrome/browser/resources/settings/printing_page/cups_printer_details_page.js
[add] https://crrev.com/d20a9e9743a868b37801b6d3fcf61a5d5a6c0da4/chrome/browser/resources/settings/printing_page/cups_printer_shared_css.html
[modify] https://crrev.com/d20a9e9743a868b37801b6d3fcf61a5d5a6c0da4/chrome/browser/resources/settings/printing_page/cups_printers.html
[modify] https://crrev.com/d20a9e9743a868b37801b6d3fcf61a5d5a6c0da4/chrome/browser/resources/settings/printing_page/cups_printers.js
[modify] https://crrev.com/d20a9e9743a868b37801b6d3fcf61a5d5a6c0da4/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js
[modify] https://crrev.com/d20a9e9743a868b37801b6d3fcf61a5d5a6c0da4/chrome/browser/resources/settings/printing_page/cups_printers_list.html
[modify] https://crrev.com/d20a9e9743a868b37801b6d3fcf61a5d5a6c0da4/chrome/browser/resources/settings/printing_page/cups_printers_list.js
[add] https://crrev.com/d20a9e9743a868b37801b6d3fcf61a5d5a6c0da4/chrome/browser/resources/settings/printing_page/cups_set_manufacturer_model_behavior.html
[add] https://crrev.com/d20a9e9743a868b37801b6d3fcf61a5d5a6c0da4/chrome/browser/resources/settings/printing_page/cups_set_manufacturer_model_behavior.js
[modify] https://crrev.com/d20a9e9743a868b37801b6d3fcf61a5d5a6c0da4/chrome/browser/resources/settings/printing_page/printing_page.html
[modify] https://crrev.com/d20a9e9743a868b37801b6d3fcf61a5d5a6c0da4/chrome/browser/resources/settings/printing_page/printing_page.js
[modify] https://crrev.com/d20a9e9743a868b37801b6d3fcf61a5d5a6c0da4/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/d20a9e9743a868b37801b6d3fcf61a5d5a6c0da4/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/d20a9e9743a868b37801b6d3fcf61a5d5a6c0da4/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/d20a9e9743a868b37801b6d3fcf61a5d5a6c0da4/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h

Merge request for CL in comment#18.

This bug requires manual review: There is .grd file changes and we are only 28 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

I think you'll need the CL in #17 as well.

Oh, right! Thanks for your reminder! Merge request for CLs in #17 and #18.

Approving merge to M61 Chrome OS.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49a912367480653ed50aeede748662a05d18bd8e

commit 49a912367480653ed50aeede748662a05d18bd8e
Author: xdai <xdai@chromium.org>
Date: Thu Aug 10 17:03:01 2017

[Merge to M61] Implement a reverse lookup for printer make and model.

We need to generate a make and model string from a PpdReference for edit
to behave reasonably.  So, lookup make and model from our PPD index.
Because we don't want to assume anything about the relationship of the
effective_make_and_model strings and manufacturer names, iterate through
all of them.

TBR=xdai@chromium.org, skau@chromium.org
(cherry picked from commit 7f57a92464231ba64c0dd18d014d4a96c6e12873)

Bug:  685673 
Change-Id: I016e2cbc45abc9ee6e8a6edf556a962c07c94541
Reviewed-on: https://chromium-review.googlesource.com/592767
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491068}
Reviewed-on: https://chromium-review.googlesource.com/610514
Cr-Commit-Position: refs/branch-heads/3163@{#433}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/49a912367480653ed50aeede748662a05d18bd8e/chromeos/printing/ppd_provider.cc
[modify] https://crrev.com/49a912367480653ed50aeede748662a05d18bd8e/chromeos/printing/ppd_provider.h
[modify] https://crrev.com/49a912367480653ed50aeede748662a05d18bd8e/chromeos/printing/ppd_provider_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6423bc91250c866792073652f5668afdd03128f8

commit 6423bc91250c866792073652f5668afdd03128f8
Author: xdai <xdai@chromium.org>
Date: Thu Aug 10 17:48:29 2017

[Merge to M61] [CUPS] Add the ability to edit a printer's setup

Currently, if a printer is setup incorrectly on initial configuration,
there is no way to correct for this except to remove the printer and add
it as new. We should add the ability to Edit the printer setup.

This CL removed the old CUPS printer details page and replaced it with
the Edit Printer dialog.

TBR=michaelpg@chromium.org, skau@chromium.org
(cherry picked from commit d20a9e9743a868b37801b6d3fcf61a5d5a6c0da4)

Bug:  685673 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3115bcd9a68ea1e2ce6ad49b3db787bcc0ec13d3
Reviewed-on: https://chromium-review.googlesource.com/582271
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492181}
Reviewed-on: https://chromium-review.googlesource.com/610703
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#436}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/6423bc91250c866792073652f5668afdd03128f8/chrome/browser/resources/settings/printing_page/compiled_resources2.gyp
[modify] https://crrev.com/6423bc91250c866792073652f5668afdd03128f8/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
[modify] https://crrev.com/6423bc91250c866792073652f5668afdd03128f8/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js
[modify] https://crrev.com/6423bc91250c866792073652f5668afdd03128f8/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
[modify] https://crrev.com/6423bc91250c866792073652f5668afdd03128f8/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.js
[add] https://crrev.com/6423bc91250c866792073652f5668afdd03128f8/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.html
[add] https://crrev.com/6423bc91250c866792073652f5668afdd03128f8/chrome/browser/resources/settings/printing_page/cups_edit_printer_dialog.js
[delete] https://crrev.com/1765a2a95967802c4ad45f3129deeaaec957f66d/chrome/browser/resources/settings/printing_page/cups_printer_details_page.html
[delete] https://crrev.com/1765a2a95967802c4ad45f3129deeaaec957f66d/chrome/browser/resources/settings/printing_page/cups_printer_details_page.js
[add] https://crrev.com/6423bc91250c866792073652f5668afdd03128f8/chrome/browser/resources/settings/printing_page/cups_printer_shared_css.html
[modify] https://crrev.com/6423bc91250c866792073652f5668afdd03128f8/chrome/browser/resources/settings/printing_page/cups_printers.html
[modify] https://crrev.com/6423bc91250c866792073652f5668afdd03128f8/chrome/browser/resources/settings/printing_page/cups_printers.js
[modify] https://crrev.com/6423bc91250c866792073652f5668afdd03128f8/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js
[modify] https://crrev.com/6423bc91250c866792073652f5668afdd03128f8/chrome/browser/resources/settings/printing_page/cups_printers_list.html
[modify] https://crrev.com/6423bc91250c866792073652f5668afdd03128f8/chrome/browser/resources/settings/printing_page/cups_printers_list.js
[add] https://crrev.com/6423bc91250c866792073652f5668afdd03128f8/chrome/browser/resources/settings/printing_page/cups_set_manufacturer_model_behavior.html
[add] https://crrev.com/6423bc91250c866792073652f5668afdd03128f8/chrome/browser/resources/settings/printing_page/cups_set_manufacturer_model_behavior.js
[modify] https://crrev.com/6423bc91250c866792073652f5668afdd03128f8/chrome/browser/resources/settings/printing_page/printing_page.html
[modify] https://crrev.com/6423bc91250c866792073652f5668afdd03128f8/chrome/browser/resources/settings/printing_page/printing_page.js
[modify] https://crrev.com/6423bc91250c866792073652f5668afdd03128f8/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/6423bc91250c866792073652f5668afdd03128f8/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/6423bc91250c866792073652f5668afdd03128f8/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/6423bc91250c866792073652f5668afdd03128f8/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa034cb19608796ffca855be881271cfbd9a9129

commit fa034cb19608796ffca855be881271cfbd9a9129
Author: xdai <xdai@chromium.org>
Date: Fri Aug 11 00:23:37 2017

[CUPS] Fix a DCHECK error.

It looks like DCHECK are eliminated in optimization in release build,
thus it's possible we get an empty callback id. Change it to CHECK.

Bug:  685673 
Change-Id: I6c3badb4eab1d320c5bdb8848c36f8e0145b7cb7
Reviewed-on: https://chromium-review.googlesource.com/611317
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493611}
[modify] https://crrev.com/fa034cb19608796ffca855be881271cfbd9a9129/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cfd61cd6a442aeb8bb9664663e006950a60a4e2

commit 8cfd61cd6a442aeb8bb9664663e006950a60a4e2
Author: xdai <xdai@chromium.org>
Date: Fri Aug 11 15:54:54 2017

[Merge to M61][CUPS] Fix a DCHECK error.

It looks like DCHECK are eliminated in optimization in release build,
thus it's possible we get an empty callback id. Change it to CHECK.

TBR=michaelpg@chromium.org
(cherry picked from commit fa034cb19608796ffca855be881271cfbd9a9129)

Bug:  685673 
Change-Id: I6c3badb4eab1d320c5bdb8848c36f8e0145b7cb7
Reviewed-on: https://chromium-review.googlesource.com/611317
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#493611}
Reviewed-on: https://chromium-review.googlesource.com/611666
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#488}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/8cfd61cd6a442aeb8bb9664663e006950a60a4e2/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c39438cf45dcc73c901103aa7a828e21b8e052a5

commit c39438cf45dcc73c901103aa7a828e21b8e052a5
Author: xdai <xdai@chromium.org>
Date: Fri Aug 11 16:03:21 2017

[CUPS] Clean up the unused strings.

Since the strings for edit-printer-dialog was added first to catch the
string cut-date (https://chromium-review.googlesource.com/c/590307), the
unused strings were not cleaned up in the original CL. Clean it up here.

Bug:  685673 
Change-Id: Ic0792ea5eab870d0921fc1c109661ee95f2b94ee
Reviewed-on: https://chromium-review.googlesource.com/611407
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493761}
[modify] https://crrev.com/c39438cf45dcc73c901103aa7a828e21b8e052a5/chrome/app/settings_strings.grdp
[modify] https://crrev.com/c39438cf45dcc73c901103aa7a828e21b8e052a5/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5609820150169b471ee1da28275ba50e79abc8b2

commit 5609820150169b471ee1da28275ba50e79abc8b2
Author: xdai <xdai@chromium.org>
Date: Tue Aug 15 00:50:34 2017

[CUPS] More cleanup of the CUPS details page.

It's leftover dead code after removing the CUPS details page in

https: //chromium-review.googlesource.com/c/582271.
Bug:  685673 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie38ec5698423d25047caf7a5247f5c71ac25deeb
Reviewed-on: https://chromium-review.googlesource.com/611656
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494273}
[modify] https://crrev.com/5609820150169b471ee1da28275ba50e79abc8b2/chrome/browser/resources/settings/printing_page/printing_page.html
[modify] https://crrev.com/5609820150169b471ee1da28275ba50e79abc8b2/chrome/browser/resources/settings/printing_page/printing_page.js

 Issue 706582  has been merged into this issue.