Search suggestions show on wrong place (when Chrome Home enabled in flags)
Reported by
ziekdo...@gmail.com,
Jan 26 2017
|
||||
Issue descriptionSteps to reproduce the problem: 1. Enable "Chrome Home" in flags 2. Type something in address bar 3. Look where suggestions show up What is the expected behavior? What went wrong? The search suggestions show up on the wrong place when Chrome Home is enabled. Did this work before? No Chrome version: 57.0.2987.9 Channel: dev OS Version: 6.0.1 Flash Version: First there wasn't any search suggestions, but now it's on the wrong place.
,
Jan 26 2017
,
Jan 27 2017
,
Jan 27 2017
Fix already in pregress: https://codereview.chromium.org/2652883002/
,
Jan 27 2017
progress*
,
Jan 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f0183c3f049882c0de912cf468d01e8f79790ce commit 2f0183c3f049882c0de912cf468d01e8f79790ce Author: mdjones <mdjones@chromium.org> Date: Tue Jan 31 17:05:15 2017 Omnibox results show correctly for Chrome Home This change allows the omnibox's suggestions to show inside of the bottom sheet for Chrome Home. To do this, a second results container was added to the bottom sheet (the first being a child of the root coordinator layout). The results container that is acutally used will depend on whether or not Chrome Home is enabled. The results container is also no longer responsible for fading out the web contents when the omnibox is focused. This view is now an independent child of the root coordinator layout so that it can function with and without Chrome Home being enabled. BUG=671361, 685661 Review-Url: https://codereview.chromium.org/2652883002 Cr-Commit-Position: refs/heads/master@{#447249} [modify] https://crrev.com/2f0183c3f049882c0de912cf468d01e8f79790ce/chrome/android/java/res/layout/bottom_control_container.xml [modify] https://crrev.com/2f0183c3f049882c0de912cf468d01e8f79790ce/chrome/android/java/res/layout/main.xml [modify] https://crrev.com/2f0183c3f049882c0de912cf468d01e8f79790ce/chrome/android/java/res/layout/omnibox_results_container.xml [modify] https://crrev.com/2f0183c3f049882c0de912cf468d01e8f79790ce/chrome/android/java/res/values/colors.xml [modify] https://crrev.com/2f0183c3f049882c0de912cf468d01e8f79790ce/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBar.java [modify] https://crrev.com/2f0183c3f049882c0de912cf468d01e8f79790ce/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/2f0183c3f049882c0de912cf468d01e8f79790ce/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java [modify] https://crrev.com/2f0183c3f049882c0de912cf468d01e8f79790ce/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java [modify] https://crrev.com/2f0183c3f049882c0de912cf468d01e8f79790ce/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java [modify] https://crrev.com/2f0183c3f049882c0de912cf468d01e8f79790ce/chrome/android/java/src/org/chromium/chrome/browser/widget/BottomSheet.java
,
Jan 31 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by rsgav...@chromium.org
, Jan 26 2017Labels: triage-te