New issue
Advanced search Search tips

Issue 685657 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 685355



Sign in to add a comment

setValueAtTime(1, -1) throws InvalidAccessError instead of TypeError

Project Member Reported by rtoy@chromium.org, Jan 26 2017 
The spec says setValueAtTime should throw TypeError if the start time is negative or not a finite number.

linearRamp, exponentialRamp, setTarget, and setValueCurve also do not throw TypeError.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36682d2fd06777d9dd371416fff959aefa36c14a

commit 36682d2fd06777d9dd371416fff959aefa36c14a
Author: rtoy <rtoy@chromium.org>
Date: Wed Jun 07 23:55:18 2017

Throw RangeError instead of InvalidAccessError for invalid times

Automation methods are supposed to throw a RangeError if the start time
or time constant are invalid.  Currently they throw
InvalidAccessError.

See spec issue: https://github.com/WebAudio/web-audio-api/issues/1182

BUG= 685657 ,  726793 
TEST=dom-exceptions.html,
AudioParam/audioparam-exceptional-values.html,
AudioParam/audioparam-method-channing.html

Review-Url: https://codereview.chromium.org/2656993002
Cr-Commit-Position: refs/heads/master@{#477812}

[add] https://crrev.com/36682d2fd06777d9dd371416fff959aefa36c14a/third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/webaudio/dom-exceptions-expected.txt
[modify] https://crrev.com/36682d2fd06777d9dd371416fff959aefa36c14a/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-exceptional-values.html
[modify] https://crrev.com/36682d2fd06777d9dd371416fff959aefa36c14a/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-method-chaining.html
[modify] https://crrev.com/36682d2fd06777d9dd371416fff959aefa36c14a/third_party/WebKit/LayoutTests/webaudio/dom-exceptions-expected.txt
[modify] https://crrev.com/36682d2fd06777d9dd371416fff959aefa36c14a/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp

Comment 2 by rtoy@chromium.org, Jun 8 2017

Status: Fixed (was: Started)
►

Sign in to add a comment