New issue
Advanced search Search tips

Issue 685655 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue webrtc:7060



Sign in to add a comment

Launch bug for promise-based RTCPeerConnection.getStats

Project Member Reported by hbos@chromium.org, Jan 26 2017

Issue description

The RTCPeerConnection.getStats[1] should be unflagged as soon as everything deemed critical to support has been implemented and the spec is likely to not drastically change.

All stats objects are described here[2]. The stats objects are dictionaries and only the supported and available stats are returned at the time of calling getStats.
The launch will include most stats, with more stats being added in future releases.

For a complete implementation of getStats, see bug[3] or overview in code[4].

This bug will be updated with launch-related status and blocked on only bugs that need solving in order to launch.

[1] https://w3c.github.io/webrtc-pc/
[2] https://w3c.github.io/webrtc-stats/
[3] https://bugs.chromium.org/p/webrtc/issues/detail?id=7060
[4] https://cs.chromium.org/chromium/src/third_party/webrtc/api/stats/rtcstats_objects.h

 

Comment 1 by hbos@chromium.org, Jan 26 2017

Blocking: webrtc:7060

Comment 2 by hbos@chromium.org, Jan 27 2017

We have implemented enough stats that exposing getStats makes sense to do now.
Here's an overview: https://docs.google.com/document/d/1Wc6a4o0PqTxIWD7LM_smA7Z0GZUTy6XOgr1qyS4M7hQ/edit?usp=sharing

With https://codereview.webrtc.org/2619353007 all recent spec changes will be implemented, and stats just need to be added, not modified.

RTCMediaStreamTrackStats has been modified to be per-attachment to the peer connection and this has been implemented. This was one of the previous blockers.

The other significant risk to have a big impact on the API is the discussion about the selector argument, which if added is an optional argument. This does not block exposing parameterless getStats.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68f8e256dc7c7369127bd345100bcf776fa8acc0

commit 68f8e256dc7c7369127bd345100bcf776fa8acc0
Author: hbos <hbos@chromium.org>
Date: Tue Jan 31 12:26:23 2017

Unflag promise-based RTCPeerConnection.getStats.

Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/bG-3TFOZC3s

BUG= chromium:685655 

Review-Url: https://codereview.chromium.org/2660163002
Cr-Commit-Position: refs/heads/master@{#447220}

[modify] https://crrev.com/68f8e256dc7c7369127bd345100bcf776fa8acc0/chrome/browser/media/webrtc/webrtc_browsertest.cc
[modify] https://crrev.com/68f8e256dc7c7369127bd345100bcf776fa8acc0/chrome/browser/media/webrtc/webrtc_stats_perf_browsertest.cc
[modify] https://crrev.com/68f8e256dc7c7369127bd345100bcf776fa8acc0/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/68f8e256dc7c7369127bd345100bcf776fa8acc0/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/68f8e256dc7c7369127bd345100bcf776fa8acc0/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl
[modify] https://crrev.com/68f8e256dc7c7369127bd345100bcf776fa8acc0/third_party/WebKit/Source/modules/peerconnection/RTCStatsReport.idl
[modify] https://crrev.com/68f8e256dc7c7369127bd345100bcf776fa8acc0/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Comment 5 by hbos@chromium.org, Jan 31 2017

Labels: OWP-Type-ChangeAPI
Status: Verified (was: Started)
Labels: -Type-Bug Type-Feature

Sign in to add a comment