New issue
Advanced search Search tips

Issue 685623 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 642722



Sign in to add a comment

Investigate high number of CSS files on Android that use all of their rules

Project Member Reported by csharrison@chromium.org, Jan 26 2017

Issue description

The new lazy css metric Style.LazyUsage.Percent shows that ~32% of all author style sheets use 100% of their rules.

This is much higher than expected, and we should see if there is an easy way to separate out these sheets beforehand, to avoid lazily parsing them.
 
Blocking: 642722
Components: Blink>CSS
Owner: csharrison@chromium.org
Status: Assigned (was: Untriaged)
Labels: Update-Quarterly
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/146eafbb2d1135f23696e2acca9a9c79cfa9b871

commit 146eafbb2d1135f23696e2acca9a9c79cfa9b871
Author: csharrison <csharrison@chromium.org>
Date: Tue Feb 14 17:40:33 2017

[LazyParseCSS] Add metrics for total # of rules at 0% and 100% usage

Metrics on Android were showing large % of sheets with 100% usage,
that we still lazily parse. This patch will help illuminate if this is an issue
in practice, by logging how much smaller these are than the average
sheet we lazily parse.

Ideally, these will be small enough that we won't need to add any gating
behavior and we can still lazily parse these, even if they don't need it.

BUG= 685623 

Review-Url: https://codereview.chromium.org/2687023003
Cr-Commit-Position: refs/heads/master@{#450397}

[modify] https://crrev.com/146eafbb2d1135f23696e2acca9a9c79cfa9b871/third_party/WebKit/Source/core/css/parser/CSSLazyParsingState.cpp
[modify] https://crrev.com/146eafbb2d1135f23696e2acca9a9c79cfa9b871/third_party/WebKit/Source/core/css/parser/CSSLazyParsingState.h
[modify] https://crrev.com/146eafbb2d1135f23696e2acca9a9c79cfa9b871/third_party/WebKit/Source/core/css/parser/CSSLazyParsingTest.cpp
[modify] https://crrev.com/146eafbb2d1135f23696e2acca9a9c79cfa9b871/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
[modify] https://crrev.com/146eafbb2d1135f23696e2acca9a9c79cfa9b871/tools/metrics/histograms/histograms.xml

Comment 4 by shend@chromium.org, Apr 11 2017

Labels: Performance

Comment 5 by nainar@chromium.org, Jun 30 2017

Hi csharrison@, 

Is there an update to be had here? Thanks!
Status: WontFix (was: Assigned)
Yes I will tentatively mark this WontFix. I think the Dev data that I filed this bug for was just noisy. It does look like Android stylesheets use more rules, but only a bit more than desktop.

Sign in to add a comment