Investigate high number of CSS files on Android that use all of their rules |
||||
Issue descriptionThe new lazy css metric Style.LazyUsage.Percent shows that ~32% of all author style sheets use 100% of their rules. This is much higher than expected, and we should see if there is an easy way to separate out these sheets beforehand, to avoid lazily parsing them.
,
Feb 12 2017
,
Feb 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/146eafbb2d1135f23696e2acca9a9c79cfa9b871 commit 146eafbb2d1135f23696e2acca9a9c79cfa9b871 Author: csharrison <csharrison@chromium.org> Date: Tue Feb 14 17:40:33 2017 [LazyParseCSS] Add metrics for total # of rules at 0% and 100% usage Metrics on Android were showing large % of sheets with 100% usage, that we still lazily parse. This patch will help illuminate if this is an issue in practice, by logging how much smaller these are than the average sheet we lazily parse. Ideally, these will be small enough that we won't need to add any gating behavior and we can still lazily parse these, even if they don't need it. BUG= 685623 Review-Url: https://codereview.chromium.org/2687023003 Cr-Commit-Position: refs/heads/master@{#450397} [modify] https://crrev.com/146eafbb2d1135f23696e2acca9a9c79cfa9b871/third_party/WebKit/Source/core/css/parser/CSSLazyParsingState.cpp [modify] https://crrev.com/146eafbb2d1135f23696e2acca9a9c79cfa9b871/third_party/WebKit/Source/core/css/parser/CSSLazyParsingState.h [modify] https://crrev.com/146eafbb2d1135f23696e2acca9a9c79cfa9b871/third_party/WebKit/Source/core/css/parser/CSSLazyParsingTest.cpp [modify] https://crrev.com/146eafbb2d1135f23696e2acca9a9c79cfa9b871/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp [modify] https://crrev.com/146eafbb2d1135f23696e2acca9a9c79cfa9b871/tools/metrics/histograms/histograms.xml
,
Apr 11 2017
,
Jun 30 2017
Hi csharrison@, Is there an update to be had here? Thanks!
,
Jun 30 2017
Yes I will tentatively mark this WontFix. I think the Dev data that I filed this bug for was just noisy. It does look like Android stylesheets use more rules, but only a bit more than desktop. |
||||
►
Sign in to add a comment |
||||
Comment 1 by csharrison@chromium.org
, Jan 26 2017Components: Blink>CSS
Owner: csharrison@chromium.org
Status: Assigned (was: Untriaged)