Exiting nested fullscreen mode causes disfigured layout
Reported by
morgenst...@gmail.com,
Jan 26 2017
|
||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36 Steps to reproduce the problem: 1. click on `enter fullscreen` to request the fullscreen from the fullscreen api 2. enter the fullscreen mode of the embedded video 3. exit the fullscreen via ESC key or the exit fullscreen button of the video What is the expected behavior? Either the video fullscreen mode or both (div and video-iframe) should be exited and the layout should look like before entering the fullscreen. What went wrong? When trying to exit the video fullscreen via the exit fullscreen button of the video, nothing happens. When pressing ESC or F11 key to exit the fullscreen mode, the fullscreen mode seems to be partly, but not entirely exited. There is a big black background and UI elements that are important to use the page are not visible anymore. Did this work before? N/A Does this work in other browsers? Yes Chrome version: 55.0.2883.87 Channel: stable OS Version: 6.3 Flash Version: Shockwave Flash 24.0 r0 Firefox and Internet Explorer handle this by exiting both fullscreen modes when pressing ESC. There is also an open Stackoverflow question for this issue: http://stackoverflow.com/questions/40633223/disfigured-layout-due-to-webkit-full-screen-in-chrome
,
Jan 26 2017
Requesting bisect to determine if this was fixed by https://crrev.com/e1d42d636990425056ede44086ef49a1f8c6a0a5 or not. It seems somewhat likely, and I am probably going to revert that so it would be good to bisect before that.
,
Jan 31 2017
,
Jan 31 2017
> Requesting bisect to determine if this was fixed by https://crrev.com/e1d42d636990425056ede44086ef49a1f8c6a0a5 or not. It seems somewhat likely, and I am probably going to revert that so it would be good to bisect before that. Hi foolip, sorry, don't really understand your comment. Is this just an internal information? What does bisect mean? Thank you!
,
Jan 31 2017
Using the per-revision bisect providing the reverse bisect results, Good Build : 57.0.2944.0 (Revision : 436816) Bad Build : 57.0.2943.0 (Revision : 436483) You are probably looking for a change made after 436584 (known good), but no later than 436585 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/1a49d60bd22ef9ccb97619ba3441bbd89f4b0c3e..a2441f293224a5c5c0352f40c5e8fcbbf1a5a051 From the CL above, suspecting the following change Review-Url: https://codereview.chromium.org/2550703002 Note : Tagging this with RB-Stable for M-56 for consideration to merge into M-56. Thanks!
,
Jan 31 2017
#4, a bisect is when you try every version of Chrome to see if the bug is there, until you find the exact version where the bug was introduced. There are scripts for doing this, and from #5 I know now which change caused the problem. hdodda@, can you also confirm that the problem remains on ToT? https://codereview.chromium.org/2652763011 (also merged to M57) fixed one problem from https://codereview.chromium.org/2550703002 so it seems possible this was fixed by that.
,
Feb 1 2017
Tested on mac os 10.12.2 , ubuntu 14.04 and windows 7 using latest chrome canary M58 #58.0.2998.0 and issue is not reproduced. Thanks!
,
Feb 1 2017
Great, thank you!
,
Feb 6 2017
foolip@: Could you please change the issue status to Fixed if there are no further work to be done.And also please merge into M57.
,
Feb 7 2017
Closing, the fix has already been merged to M57 in https://chromium.googlesource.com/chromium/src.git/+/c3055f3d690fd3d9a4a905cf705c145609714a0a
,
Feb 7 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-57; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-57 label, otherwise remove Merge-TBD label. Thanks.
,
Feb 7 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by e...@chromium.org
, Jan 26 2017Owner: foolip@chromium.org
Status: Assigned (was: Unconfirmed)