New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685570 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Fix the toolbar menu opening at beginning of test

Project Member Reported by gambard@chromium.org, Jan 26 2017

Issue description

With the update of Earl Grey, when the toolbar menu is opened at the beginning of test, the animation to display the NTP is not taken into account by Earl Grey. Earl Grey successfully tap on the toolbar button but nothing happens.
The test fails on the next steps (selecting the entry on the toolbar menu).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0f80f1c19257bfd18968479860caa0640bbca83

commit c0f80f1c19257bfd18968479860caa0640bbca83
Author: gambard <gambard@chromium.org>
Date: Thu Jan 26 10:38:41 2017

Add a fixed delay in history before opening tool menu

The animation of the NTP is not taken into account by Earl Grey.
This CL adds a delay to make sure the toolmenu can be interacted with.

BUG= 685570 

Review-Url: https://codereview.chromium.org/2658023002
Cr-Commit-Position: refs/heads/master@{#446297}

[modify] https://crrev.com/c0f80f1c19257bfd18968479860caa0640bbca83/ios/chrome/browser/ui/history/history_ui_egtest.mm

Comment 3 by baxley@chromium.org, Jan 26 2017

Labels: -Pri-3 Pri-1
Status: Started (was: Assigned)
So far I couldn't repro, we're going to try this change inside ChromeEarlGreyUI openToolsMenu, and see if it makes a difference on the bots.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fb5e88be8e7123c26507d88584399e6b237be1d

commit 8fb5e88be8e7123c26507d88584399e6b237be1d
Author: baxley <baxley@chromium.org>
Date: Thu Jan 26 21:19:49 2017

Move delay before tapping tools menu to global location.

Multiple tests have been flaky, so moving it to the helper in
ChromeEarlGreyUI, will see if this is the problem.

BUG= 685570 

Review-Url: https://codereview.chromium.org/2660513002
Cr-Commit-Position: refs/heads/master@{#446450}

[modify] https://crrev.com/8fb5e88be8e7123c26507d88584399e6b237be1d/ios/chrome/browser/ui/history/history_ui_egtest.mm
[modify] https://crrev.com/8fb5e88be8e7123c26507d88584399e6b237be1d/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm

I need to see what happens with this bug in EarlGrey:
https://github.com/google/EarlGrey/issues/422

I'll ping them, and if it doesn't sound like they'll fix it, I'll look at some workaround options. Disabling synchronization fixed some cases, and not calling clearTouches in EarlGrey code may also help.
Labels: -ReleaseBlock-Stable
This isn't tied to a specific disabled test (those all have separate bugs), so I removed RBS. This is still something important to fix at the framework level to make our tests more robust, so leaving as P1.

Comment 7 by cma...@chromium.org, Mar 10 2017

Components: Test>iOS
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fac53279853313e860a355e73db623995be5855

commit 7fac53279853313e860a355e73db623995be5855
Author: Mike Baxley <baxley@chromium.org>
Date: Wed Nov 22 01:59:20 2017

Remove delay when opening tools menu.

Currently there is a 0.5 second delay to work around EarlGrey
tapping problems. It appears to be fixed now.

Bug:  685570 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id79905f1e4423a5069de1cd06217ccf88230c9cc
Reviewed-on: https://chromium-review.googlesource.com/783654
Reviewed-by: Menglu Huang <huangml@chromium.org>
Commit-Queue: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518497}
[modify] https://crrev.com/7fac53279853313e860a355e73db623995be5855/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm

Comment 9 by baxley@chromium.org, Nov 22 2017

Status: Fixed (was: Started)

Sign in to add a comment