New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685561 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocked on:
issue 685619

Blocking:
issue 682617



Sign in to add a comment

Need bots for v8_enable_csa_verifier

Project Member Reported by danno@chromium.org, Jan 26 2017

Issue description

I am in the process of introducing a new configuration to V8 builds called v8_enable_csa_verifier which does extra checking at runtime, including at snapshot build time, to find mistakes in the usage of the CodeStubAssembler. The flag will be disabled by default for both debug and release builds.

One this flag is in place, we will new builders to verify correctness when the flag is activated. It must be used in the presence of a debug or optdebug build, since the verification is based on runtime DCHECKS. 

At the very least, we'll need two bots on the waterfall checking the v8_enable_csa_verifier=true, one 32 and one 64 bit. ia32 and x64 are fine.

The mksnapshot execution during normal compilation will catch 95% of all problems with this flag on, but running the tests with this configuration will also uncover some non-zero number of problems, so that would be good to have, too.

Nice to have: try bots that check that both configurations are still green as part of the CQ.


 

Comment 1 by danno@chromium.org, Jan 26 2017

Labels: -Pri-3 Pri-1
Components: Infra>Client>V8
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/9423cf1126d30b606f7d1a2b02aab7ee3393b9ca

commit 9423cf1126d30b606f7d1a2b02aab7ee3393b9ca
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Jan 26 10:38:51 2017

V8: Add bots to verify csa

BUG= 685561 

Change-Id: Id0864d38130b0b03a5e61c6e20cd48ab601cce0a
Reviewed-on: https://chromium-review.googlesource.com/433697
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/9423cf1126d30b606f7d1a2b02aab7ee3393b9ca/masters/master.client.v8/master.cfg
[modify] https://crrev.com/9423cf1126d30b606f7d1a2b02aab7ee3393b9ca/masters/master.client.v8/slaves.cfg
[modify] https://crrev.com/9423cf1126d30b606f7d1a2b02aab7ee3393b9ca/masters/master.tryserver.v8/master.cfg
[modify] https://crrev.com/9423cf1126d30b606f7d1a2b02aab7ee3393b9ca/masters/master.tryserver.v8/slaves.cfg
[modify] https://crrev.com/9423cf1126d30b606f7d1a2b02aab7ee3393b9ca/scripts/slave/recipe_modules/v8/builders.py
[add] https://crrev.com/9423cf1126d30b606f7d1a2b02aab7ee3393b9ca/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___verify_csa.json
[add] https://crrev.com/9423cf1126d30b606f7d1a2b02aab7ee3393b9ca/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___verify_csa.json
[add] https://crrev.com/9423cf1126d30b606f7d1a2b02aab7ee3393b9ca/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_verify_csa_rel_ng.json
[add] https://crrev.com/9423cf1126d30b606f7d1a2b02aab7ee3393b9ca/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_verify_csa_rel_ng_triggered.json
[add] https://crrev.com/9423cf1126d30b606f7d1a2b02aab7ee3393b9ca/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_verify_csa_rel_ng.json
[add] https://crrev.com/9423cf1126d30b606f7d1a2b02aab7ee3393b9ca/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_verify_csa_rel_ng_triggered.json

Blockedon: 685619
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/c9d7215ed4f7bacb53b30111127214bab8fdc408

commit c9d7215ed4f7bacb53b30111127214bab8fdc408
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Jan 26 13:33:48 2017

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/e3c7446a1e0247de476e8b4e3d4562aa5bdc8306

commit e3c7446a1e0247de476e8b4e3d4562aa5bdc8306
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Jan 26 13:44:02 2017

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/169b85673f2f8592c2bb89acd73f1cd25fbe58b5

commit 169b85673f2f8592c2bb89acd73f1cd25fbe58b5
Author: machenbach <machenbach@chromium.org>
Date: Thu Jan 26 14:10:55 2017

[build] Add configs for verify-csa bots

This adds MB configs for the four verify-csa bots (gn only).

BUG= chromium:685561 
NOTRY=true
NOTREECHECKS=true
TBR=danno@chromium.org, kjellander@chromium.org

Review-Url: https://codereview.chromium.org/2659583002
Cr-Commit-Position: refs/heads/master@{#42698}

[modify] https://crrev.com/169b85673f2f8592c2bb89acd73f1cd25fbe58b5/infra/mb/mb_config.pyl

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5129880ad59d44e6c71c7e5db3fc7d54fd803ae2

commit 5129880ad59d44e6c71c7e5db3fc7d54fd803ae2
Author: machenbach <machenbach@chromium.org>
Date: Thu Jan 26 14:21:12 2017

[CQ] Add verify-csa bot experimentally to CQ

BUG= chromium:685561 
NOTRY=true
TBR=danno@chromium.org, kjellander@chromium.org

Review-Url: https://codereview.chromium.org/2652653013
Cr-Commit-Position: refs/heads/master@{#42700}

[modify] https://crrev.com/5129880ad59d44e6c71c7e5db3fc7d54fd803ae2/infra/config/cq.cfg

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/aaaffd37581cd4dbaef0391e6475054826de121a

commit aaaffd37581cd4dbaef0391e6475054826de121a
Author: machenbach <machenbach@chromium.org>
Date: Fri Jan 27 15:34:45 2017

[CQ] Make verify-csa bots block CQ

BUG= chromium:685561 
NOTRY=true
TBR=danno@chromium.org, kjellander@chromium.org

Review-Url: https://codereview.chromium.org/2650383008
Cr-Commit-Position: refs/heads/master@{#42743}

[modify] https://crrev.com/aaaffd37581cd4dbaef0391e6475054826de121a/infra/config/cq.cfg

Labels: -Type-Bug Type-Feature
Status: Fixed (was: Started)
Blocking: 682617

Sign in to add a comment