New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 685548 link

Starred by 6 users
Status: Verified
Owner:
joelhockey@chromium.org
Closed: Feb 2017
Cc:
█ dsansome@chromium.org
█ emso@chromium.org
j...@chromium.org
flyboy@chromium.org
rauch+monorail-auto@google.com
█ orodley+autocc@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Git



Sign in to add a comment

Faulty reviewed-on URL in history entry

Project Member Reported by emso@chromium.org, Jan 26 2017 
Looking at history for 
https://cs-staging.chromium.org/chromium/build/masters/master.chromium.infra.codesearch/master.cfg?rcl=b62b4e18de7af3fa9cf3a78a68363465901833ef
and the Reviewed-on URL for the first history entry is not working. It appears to be merged with 'Reviewed-by' on the next line.

The URL in the entry below works.

Comment 1 by dsansome@chromium.org, Feb 9 2017

Cc: dsansome@chromium.org
 Issue 690221  has been merged into this issue.

Comment 2 by emso@chromium.org, Feb 20 2017 

 Issue 694223  has been merged into this issue.

Comment 3 by dsansome@chromium.org, Feb 22 2017 

 Issue 694498  has been merged into this issue.

Comment 4 by joelhockey@chromium.org, Feb 27 2017

Owner: joelhockey@chromium.org

Comment 5 by joelhockey@chromium.org, Feb 27 2017 

The LinkDetector code that is used allows links to wrap over multiple lines.  When the second line text contains dash char, it assumes that this is meant to be part of the full URL.  Fix is to turn off multi-line detection.

Comment 6 by joelhockey@chromium.org, Feb 27 2017 

Fixed in cl/148609805

Comment 7 by joelhockey@chromium.org, Feb 27 2017

Status: Started (was: Available)

Comment 8 by joelhockey@chromium.org, Feb 27 2017

Status: Fixed (was: Started)

Comment 9 by joelhockey@chromium.org, Feb 28 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment