New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685523 link

Starred by 1 user

Issue metadata

Status: Closed
Owner:
Last visit > 30 days ago
Closed: Aug 17
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Cleanup TODOs in the code

Project Member Reported by dim...@chromium.org, Jan 26 2017

Issue description

As part of FixIt.
 
Owner: dim...@chromium.org
Status: Assigned (was: Untriaged)
Need to create a doc a link here.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e468760955a427460f9d8ebb604f0e6a24a6c35

commit 9e468760955a427460f9d8ebb604f0e6a24a6c35
Author: fgorski <fgorski@chromium.org>
Date: Wed Mar 29 22:53:41 2017

[Offline pages] Removing obsolete TODOs as part of PE fixit

Removing TODOs, which are obsolete or which make no sense to act upon
at this point in time.

BUG= 685523 
R=chili@chromium.org

Review-Url: https://codereview.chromium.org/2782673002
Cr-Commit-Position: refs/heads/master@{#460562}

[modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java
[modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
[modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadItem.java
[modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc
[modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc
[modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/chrome/browser/android/offline_pages/request_coordinator_factory.cc
[modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/components/offline_pages/core/background/request_queue.cc
[modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/components/offline_pages/core/background/request_queue_store_sql.cc
[modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/components/offline_pages/core/background/request_queue_unittest.cc
[modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/components/offline_pages/core/background/save_page_request.cc
[modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/components/offline_pages/core/offline_page_archiver.h
[modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/components/offline_pages/core/offline_page_metadata_store_impl_unittest.cc
[modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/components/offline_pages/core/offline_page_metadata_store_sql.cc
[modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/components/offline_pages/core/offline_page_model_impl.cc
[modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/components/offline_pages/core/offline_page_test_archiver.h
[modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/components/offline_pages/core/offline_page_test_store.cc
[modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/components/offline_pages/core/offline_store_types.h

Status: Closed (was: Assigned)
There is a newer bug on this: bug 714264.
Not duplicate but superceding.

Sign in to add a comment