As part of FixIt.
Need to create a doc a link here.
Can be removed: https://cs.chromium.org/chromium/src/chrome/browser/android/offline_pages/recent_tab_helper.cc?rcl=e507bb334d3c66917eec47fbc476ed0a7d62f33f&l=176 Both TODOs in this fiel can be just removed: https://cs.chromium.org/chromium/src/components/offline_pages/core/downloads/download_ui_item.cc?rcl=de3f4bede90e857cb62f9f0160e80659561d9324&l=27 Can be removed, no UMA here is really necessary. UMA reporting user actions should be closer to initiating of the user actions. https://cs.chromium.org/chromium/src/components/offline_pages/core/downloads/download_ui_adapter.cc?rcl=de3f4bede90e857cb62f9f0160e80659561d9324&l=322 Should remove this one (work already done): https://cs.chromium.org/chromium/src/components/offline_pages/core/downloads/download_ui_adapter_unittest.cc?rcl=de3f4bede90e857cb62f9f0160e80659561d9324&l=348 Don't do anything (waiting for future work): https://cs.chromium.org/chromium/src/chrome/browser/android/offline_pages/offline_page_utils.cc?rcl=de3f4bede90e857cb62f9f0160e80659561d9324&l=241 https://cs.chromium.org/chromium/src/components/offline_pages/core/offline_page_model_impl_unittest.cc?rcl=de3f4bede90e857cb62f9f0160e80659561d9324&l=1303
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e468760955a427460f9d8ebb604f0e6a24a6c35 commit 9e468760955a427460f9d8ebb604f0e6a24a6c35 Author: fgorski <fgorski@chromium.org> Date: Wed Mar 29 22:53:41 2017 [Offline pages] Removing obsolete TODOs as part of PE fixit Removing TODOs, which are obsolete or which make no sense to act upon at this point in time. BUG= 685523 R=chili@chromium.org Review-Url: https://codereview.chromium.org/2782673002 Cr-Commit-Position: refs/heads/master@{#460562} [modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java [modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java [modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadItem.java [modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc [modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc [modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/chrome/browser/android/offline_pages/request_coordinator_factory.cc [modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/components/offline_pages/core/background/request_queue.cc [modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/components/offline_pages/core/background/request_queue_store_sql.cc [modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/components/offline_pages/core/background/request_queue_unittest.cc [modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/components/offline_pages/core/background/save_page_request.cc [modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/components/offline_pages/core/offline_page_archiver.h [modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/components/offline_pages/core/offline_page_metadata_store_impl_unittest.cc [modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/components/offline_pages/core/offline_page_metadata_store_sql.cc [modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/components/offline_pages/core/offline_page_model_impl.cc [modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/components/offline_pages/core/offline_page_test_archiver.h [modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/components/offline_pages/core/offline_page_test_store.cc [modify] https://crrev.com/9e468760955a427460f9d8ebb604f0e6a24a6c35/components/offline_pages/core/offline_store_types.h
There is a newer bug on this: bug 714264. Not duplicate but superceding.
Comment 1 by dim...@chromium.org
, Feb 8 2017Status: Assigned (was: Untriaged)