New issue
Advanced search Search tips

Issue 685520 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task



Sign in to add a comment

TextIterator/VisibleUnits should use FirstLetterPseudoElement::firstLetterTextLayoutObject instead of traversing layout tree

Project Member Reported by kojii@chromium.org, Jan 26 2017

Issue description

TextIterator and VisibleUnits traverses the layout tree to find first-letter objects.

They should probably use |FirstLetterPseudoElement::firstLetterTextLayoutObject| instead.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/dom/FirstLetterPseudoElement.cpp?q=FirstLetterPseudoElement::firstLetterTextLayoutObject&sq=package:chromium&l=97&dr=CSs

This is derived from  issue 684684 .
 
Status: Available (was: Untriaged)

Comment 2 by yosin@chromium.org, Aug 24 2017

Owner: xiaoche...@chromium.org
Status: Assigned (was: Available)
xiaochengh@, WDYT?

It seems we also change AssociatedLayoutObjectOf() to use 
|FirstLetterPseudoElement::firstLetterTextLayoutObject|.

It seems |firstLetterTextLayoutObject()| does match more than |AssociatedLayoutObjectOf()|.

Comment 3 by yosin@chromium.org, Aug 24 2017

To simplify |FirstLetterPseudoElement::firstLetterTextLayoutObject()|, it is better
to member variable |another_part_| to |LayoutTextFragment|, which is initialized
in FirstLetterPseudoElement::AttachFirstLetterTextLayoutObjects().
Cc: -yosin@chromium.org
Owner: yosin@chromium.org
Assign to yosin@ who is actively working on bugs related to ::first-letter.

Comment 5 by yosin@chromium.org, Sep 15 2017

Status: Available (was: Assigned)
Mark Available to make someone picks this up.

Comment 6 by yosin@chromium.org, Sep 15 2017

Owner: ----
Labels: Type-Task
Project Member

Comment 8 by sheriffbot@chromium.org, Nov 14

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)

Sign in to add a comment