New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 685512 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Feb 2017
Cc:
thakis@chromium.org
█ riesa@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

_CheckNoIOStreamInHeaders not catching iostream include

Project Member Reported by kjellander@chromium.org, Jan 26 2017 
In the case of https://codereview.chromium.org/2650003004 the _CheckNoIOStreamInHeaders check in https://chromium.googlesource.com/chromium/src/+/master/PRESUBMIT.py#395 failed to catch the error introduced. This meant the linux sizes step failed: https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/31922

Adding thakis@ as author of the check.

Comment 1 by thakis@chromium.org, Jan 26 2017 

I think the presubmit only checks .H files. Maybe it should check more, but iirc some tests do use iostream.

Comment 2 by kjellander@chromium.org, Feb 28 2017

Status: WontFix (was: Untriaged)
OK, I'm fine closing then.
►

Sign in to add a comment