chromeos-config-tools: unconstrained use of test files |
||||||
Issue description
the chromeos-config.gyp has this:
'includes': ['../common-mk/common_test.gypi'],
except it isn't behind USE_test or any other conditional logic which means libcros_config always links against gmock/gtest ? that doesn't look correct at all ...
maybe you meant to put that include under cros_config_unittest ? and put that target under USE_test == 1 like other gyps ?
,
Feb 17 2017
,
Feb 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a23325935e92c6fd1797fd3beabb6a4a13b6f5cd commit a23325935e92c6fd1797fd3beabb6a4a13b6f5cd Author: Simon Glass <sjg@chromium.org> Date: Tue Feb 21 22:07:51 2017 chromeos-config-tools: Drop dependency on gtest This should not be needed unless testing is enabled, so put it behind the conditional. BUG= chromium:685490 TEST=Start by emerge-reef --unmerge gtest gmock emerge-reef chromeos-config-tools FEATURES=test emerge-reef chromeos-config-tools See that it happily builds for the first emerge, then pulls in the two dependencies for the second. Change-Id: Ie36a5b2ff4ff6b60c7705c86374b6242891b29ca Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/444819 Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [modify] https://crrev.com/a23325935e92c6fd1797fd3beabb6a4a13b6f5cd/chromeos-base/chromeos-config-tools/chromeos-config-tools-9999.ebuild
,
Feb 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/d488d5f204919fea17733a464fdde84b005d6c07 commit d488d5f204919fea17733a464fdde84b005d6c07 Author: Simon Glass <sjg@chromium.org> Date: Tue Feb 21 22:07:50 2017 chromeos-config: Make test binary depend on USE=test The test binary should not be built normally. Adjust the gyp file to make it conditional on USE=test. BUG= chromium:685490 TEST=emerge-reef chromeos-config-tools with and without FEATURES=test Change-Id: Ibcf524a4ef0f7786d5c09af0a2015aa12240212a Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/444450 Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/d488d5f204919fea17733a464fdde84b005d6c07/chromeos-config/chromeos-config.gyp
,
Mar 14 2017
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sjg@chromium.org
, Jan 26 2017