New issue
Advanced search Search tips

Issue 685480 link

Starred by 0 users

Issue metadata

Status: Archived
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

imageloader should be logging to syslog

Project Member Reported by vapier@chromium.org, Jan 26 2017

Issue description

instead of logging to stderr, imageloader, as a daemon, should be using syslog

should be as simple as changing imageloader_main.cc to use brillo/syslog_logging.h instead of base/logging.h.  then changing the logging init to:

  brillo::OpenLog("imageloader", true);
  brillo::InitLog(brillo::kLogToSyslog);
 
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/imageloader/+/b0d814968fc16316486f49508c72115c3935a4bd

commit b0d814968fc16316486f49508c72115c3935a4bd
Author: Greg Kerr <kerrnel@chromium.org>
Date: Thu Jan 26 23:35:16 2017

imageloader should log to the syslog.

Changes imageloader to log to the syslog instead of stderr, since it
runs as a daemon in the background.

BUG= chromium:685480 
TEST=test_that -b ${BOARD} ${DUT_ip} imageloader

Change-Id: Ic1f30688a5a345e43aaa107b210298dde38d597a
Reviewed-on: https://chromium-review.googlesource.com/433845
Commit-Ready: Greg Kerr <kerrnel@chromium.org>
Tested-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/b0d814968fc16316486f49508c72115c3935a4bd/imageloader_main.cc

Status: Fixed (was: Started)

Comment 4 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 5 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment