[devtools] remove refresh button from watch expressions pane?
Reported by
kaycebas...@gmail.com,
Jan 26 2017
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.2992.0 Safari/537.36 Steps to reproduce the problem: 1. Go to sources panel 2. Create a watch expression 3. Debug the page What is the expected behavior? In the past, I believe the watch expression stayed the same until the developer manually refreshed it with the refresh button What went wrong? As I step through the code now, DevTools automatically updates the watch expression. So there's nothing actually wrong, DevTools is behaving in a more user-friendly fashion. However, maybe the refresh button is not needed anymore? Did this work before? N/A Chrome version: 58.0.2992.0 Channel: canary OS Version: OS X 10.11.6 Flash Version:
,
Jan 30 2017
I've seldom needed to use the refresh button. As far as I remember, the only case was: When paused at a particular line, I might change some variable in the console, and click to refresh watches to immediately see the changed expression value. We could consider auto-refreshing watches after each console evaluation. Conceivably, a watch expression of "Math.random()" would benefit from having the refresh button, but I don't know how useful that is. paulirish@, pfeldman@ do you know of other cases I'm missing?
,
Jan 30 2017
I'm unfamiliar with why we need that. Maybe kozy knows why? (Perhaps we only update watch on a few select events, but obviously not all mutations to that value). Pending the answer, I'm generally supportive of nuking the icon. (we could also convert it to a context menu item, basically: right-click > Refresh values)
,
Jan 30 2017
I'm not sure that we update watches when evaluate something in console when on pause - value could be changed after evaluation. And in case when we have some watch like "window.super_important_global_state" and would like to see changes not during stepping but after some actions in the page.
,
Jan 30 2017
Context menu item sounds good to me.
,
Nov 16 2017
To summarize, it seems that the icon adds some confusion, but it helps workflows where users use watches: - even when they are not paused - have some non-deterministic value, e.g. Math.random() I think this is sufficient reason to keep it around, but please comment if you think otherwise. |
||||
►
Sign in to add a comment |
||||
Comment 1 by eostroukhov@chromium.org
, Jan 30 2017