Discard button for notifications is disabled |
|||||
Issue descriptionChrome Version : 57.0.2970.0 OS Version: 9150.0.0 What steps will reproduce the problem? 1. Receive notifications 2. Open the message center What is the expected result? The discard button that looks like δΈ‰ works What happens instead of that? The discard button is disabled (grayed out) Please provide any additional information below. Attach a screenshot if possible. I'll attach a screenshot shortly.
,
Jan 26 2017
,
Feb 1 2017
I confirmed it on ToT. The status of the button is wrong just after the message center opens. It happens only when there ares only ARC notifications. Eliot, could you investigate? The statuses of buttons are updated in MessageCenterView::UpdateButtonBarStatus(). I think (1) this method is not called correctly when the message center opens, or (2) all notifications are treated as pinned (= non-closable) wrongly when the message center opens.
,
Feb 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/581285b278ce65ddf216a03295333bd396239c03 commit 581285b278ce65ddf216a03295333bd396239c03 Author: edcourtney <edcourtney@chromium.org> Date: Thu Feb 02 05:07:24 2017 [arc notifications] Inspect pinned flag directly for IsPinned(). When an ARC notification comes, the 'discard notifications' button in the notifications tray is greyed out until you hover over the notification. ArcCustomNotificationView::ContentViewDelegate would check whether ArcCustomNotificationView::floating_close_button_ existed to determine if the notification is pinned or not. Pinned notifications cannot be closed. The floating close button is created if the notification is not pinned. However, it is created after the check inside ContentViewDelegate. Instead, inspect the pinned state directly from ArcCustomNotificationItem. BUG= 685467 Review-Url: https://codereview.chromium.org/2670493002 Cr-Commit-Position: refs/heads/master@{#447698} [modify] https://crrev.com/581285b278ce65ddf216a03295333bd396239c03/ui/arc/notification/arc_custom_notification_view.cc
,
Feb 2 2017
,
Mar 29 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by satorux@chromium.org
, Jan 26 201747.6 KB
47.6 KB View Download