New issue
Advanced search Search tips

Issue 685464 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Wrap all tests in ARC by anonymous namespace.

Project Member Reported by hidehiko@chromium.org, Jan 26 2017

Issue description

Chrome Version: ToT
OS: Chrome

This is for tracking of clean up.
Now most of ARC tests/test fixtures are defined directly in the arc namespace.

To follow the style guide:
https://google.github.io/styleguide/cppguide.html#Unnamed_Namespaces_and_Static_Variables
It's better to put everything into anonymous namespace.
 
Ah, I found that, if we want to use friend test (incl. declaring Test fixture friend), we cannot put it into anonymous namespace.
Should we allow an exception for the case, Yusuke?

sgtm
Components: Platform>Apps>ARC
Cc: -lhchavez@chromium.org

Sign in to add a comment