Add tooltips on Clank overflow and tab switcher |
||||||||
Issue descriptionMaterial did a review of the app and recommends we add tool tips to the a) [+] “New tab” icon in the tab switcher, as well as b) Forward, Favorite, Info, and Reload icons in overflow. For b) we'd wait until after the menu is opened/user finger is released so as not to co-opt the single longpress to reload behavior.
,
Jan 26 2017
srahim@ - can you confirm the best text for Clank tooltips? Then assign to tedchoc@ when ready, no rush. My suggestions: "New tab" or "New incognito tab" "Forward" "Bookmark" "Page info" "Refresh"
,
Jan 26 2017
+srahim for real this time (please see comment 2)
,
Feb 3 2017
The tooltips you suggested LGTM. Ted, I have added message descriptions for localization below. In particular I want to be sure "Bookmark" and "Page info" are translated correctly. New tab Tooltip on Android for the button to open a new browser tab New incognito tab Tooltip on Android for the button to open a new incognito browser tab Forward Tooltip on Android for the button to advance to the next web page. Only enabled if the user has gone back to a previously opened page. Verb. Bookmark Tooltip on Android for the button to save the web page to "Bookmarks" section. Used here as the verb "to bookmark," meaning to save or mark something for future reading. Page info Tooltip on Android for the button to view information about the current web page. "Info" is short for "information." Refresh Tooltip on Android for the button to refresh the current web page
,
Feb 3 2017
,
Mar 29 2017
(removing myself and adding +cleer as the design contact)
,
May 11 2017
,
May 11 2017
,
May 16 2017
srahim@ - The tool tip for "Download" button is not on the list above. Could you also add a description to it? Thanks.
,
May 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47137024bf6d15127330336310406d3f27a3391a commit 47137024bf6d15127330336310406d3f27a3391a Author: huayinz <huayinz@chromium.org> Date: Thu May 18 01:15:32 2017 Tooltip for home page menu buttons Before the change, tooltip is only available on 'open tab' button. Now a tooltip will show as a toast for every ImageButton in main menu on a user long click. BUG= 685459 R=mdjones@chromium.org Review-Url: https://codereview.chromium.org/2891493004 Cr-Commit-Position: refs/heads/master@{#472618} [modify] https://crrev.com/47137024bf6d15127330336310406d3f27a3391a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java [modify] https://crrev.com/47137024bf6d15127330336310406d3f27a3391a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java [modify] https://crrev.com/47137024bf6d15127330336310406d3f27a3391a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuIconRowFooter.java [modify] https://crrev.com/47137024bf6d15127330336310406d3f27a3391a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java [modify] https://crrev.com/47137024bf6d15127330336310406d3f27a3391a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java [modify] https://crrev.com/47137024bf6d15127330336310406d3f27a3391a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java [modify] https://crrev.com/47137024bf6d15127330336310406d3f27a3391a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java [modify] https://crrev.com/47137024bf6d15127330336310406d3f27a3391a/chrome/android/java/src/org/chromium/chrome/browser/util/AccessibilityUtil.java [modify] https://crrev.com/47137024bf6d15127330336310406d3f27a3391a/chrome/android/java/strings/android_chrome_strings.grd
,
May 18 2017
Download Tooltip on Android for the button to download a page
,
May 19 2017
,
May 23 2017
verified on 60.0.3107.3 build |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 Deleted