If we want people to share our LevelDB, there needs to be a simple way for them to create a ModelTypeStore using the same parameters as DeviceInfo.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f1ddc6deb94f709ca8a8635d270749560295a72 commit 9f1ddc6deb94f709ca8a8635d270749560295a72 Author: maxbogue <maxbogue@chromium.org> Date: Thu Jan 26 17:49:13 2017 [Sync] Add ProfileSyncService::GetModelTypeStoreFactory. This allows other model types besides DEVICE_INFO to create ModelTypeStores that share the same LevelDB backend. BUG= 685451 Review-Url: https://codereview.chromium.org/2658743002 Cr-Commit-Position: refs/heads/master@{#446372} [modify] https://crrev.com/9f1ddc6deb94f709ca8a8635d270749560295a72/chrome/browser/sync/profile_sync_service_factory.cc [modify] https://crrev.com/9f1ddc6deb94f709ca8a8635d270749560295a72/chrome/browser/sync/profile_sync_test_util.cc [modify] https://crrev.com/9f1ddc6deb94f709ca8a8635d270749560295a72/components/browser_sync/profile_sync_service.cc [modify] https://crrev.com/9f1ddc6deb94f709ca8a8635d270749560295a72/components/browser_sync/profile_sync_service.h [modify] https://crrev.com/9f1ddc6deb94f709ca8a8635d270749560295a72/components/browser_sync/profile_sync_test_util.cc [modify] https://crrev.com/9f1ddc6deb94f709ca8a8635d270749560295a72/components/sync/device_info/device_info_sync_bridge.cc [modify] https://crrev.com/9f1ddc6deb94f709ca8a8635d270749560295a72/components/sync/device_info/device_info_sync_bridge.h [modify] https://crrev.com/9f1ddc6deb94f709ca8a8635d270749560295a72/components/sync/model/model_type_store.h [modify] https://crrev.com/9f1ddc6deb94f709ca8a8635d270749560295a72/ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc [modify] https://crrev.com/9f1ddc6deb94f709ca8a8635d270749560295a72/ios/chrome/browser/sync/ios_chrome_profile_sync_test_util.cc
Requesting merge to M57. This change is required for change in http://crbug.com/664920 to be merged into M57.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ebeaa02e3d830ebd339be4134252682fe600330 commit 2ebeaa02e3d830ebd339be4134252682fe600330 Author: Pavel Yatsuk <pavely@chromium.org> Date: Thu Feb 02 22:03:39 2017 [Sync] Add ProfileSyncService::GetModelTypeStoreFactory. This allows other model types besides DEVICE_INFO to create ModelTypeStores that share the same LevelDB backend. BUG= 685451 Review-Url: https://codereview.chromium.org/2658743002 Cr-Commit-Position: refs/heads/master@{#446372} (cherry picked from commit 9f1ddc6deb94f709ca8a8635d270749560295a72) Review-Url: https://codereview.chromium.org/2669283003 . Cr-Commit-Position: refs/branch-heads/2987@{#283} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/2ebeaa02e3d830ebd339be4134252682fe600330/chrome/browser/sync/profile_sync_service_factory.cc [modify] https://crrev.com/2ebeaa02e3d830ebd339be4134252682fe600330/chrome/browser/sync/profile_sync_test_util.cc [modify] https://crrev.com/2ebeaa02e3d830ebd339be4134252682fe600330/components/browser_sync/profile_sync_service.cc [modify] https://crrev.com/2ebeaa02e3d830ebd339be4134252682fe600330/components/browser_sync/profile_sync_service.h [modify] https://crrev.com/2ebeaa02e3d830ebd339be4134252682fe600330/components/browser_sync/profile_sync_test_util.cc [modify] https://crrev.com/2ebeaa02e3d830ebd339be4134252682fe600330/components/sync/device_info/device_info_sync_bridge.cc [modify] https://crrev.com/2ebeaa02e3d830ebd339be4134252682fe600330/components/sync/device_info/device_info_sync_bridge.h [modify] https://crrev.com/2ebeaa02e3d830ebd339be4134252682fe600330/components/sync/model/model_type_store.h [modify] https://crrev.com/2ebeaa02e3d830ebd339be4134252682fe600330/ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc [modify] https://crrev.com/2ebeaa02e3d830ebd339be4134252682fe600330/ios/chrome/browser/sync/ios_chrome_profile_sync_test_util.cc
Comment 1 by bugdroid1@chromium.org
, Jan 26 2017