New issue
Advanced search Search tips

Issue 685441 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

libdot: doesn't properly notify subscriber when localStorage preference change back to default

Project Member Reported by codr@google.com, Jan 26 2017 
Chrome Version       : 55.0.2883.95

When two windows are sharing an hterm profile and share LocalStorage, changing a preference in one should change the other.

What steps will reproduce the problem?
  1. Have two hterm windows with the same profile and localStorage.
  2. Change a preference in one of the windows from a custom value to the defined default value.

What is the expected result?
  The other window should be updated with the change.

What happens instead of that?
  The other window isn't updated with the change.

Please provide any additional information below. Attach a screenshot if
possible.
  https://chromium-review.googlesource.com/#/c/429651/

UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.95 Safari/537.36

Comment 1 Deleted

Comment 2 Deleted

Comment 3 Deleted

Comment 4 Deleted

Comment 5 Deleted

Comment 6 Deleted

Comment 7 Deleted

Project Member

Comment 8 by bugdroid1@chromium.org, May 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/b30c7d12f7f908d43c1fb2be7c6a7646bd30ac4a

commit b30c7d12f7f908d43c1fb2be7c6a7646bd30ac4a
Author: Cody Coljee-Gray <codr@google.com>
Date: Wed May 03 06:09:55 2017

libdot: fix two windows sharing prefs when resetting to defaults

If a window changes a preference to the default it will delete the
localStorage entry. When another window detects this event it should set
that preference to default. But currently it is set to the empty string.
This has caused errors when sharing display preferences between hterm
windows that share a profile.

BUG= chromium:685441 

Change-Id: I424fa40f7bfdf90811bc16e4803c01ae5f8bf7f3
Reviewed-on: https://chromium-review.googlesource.com/429651
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/b30c7d12f7f908d43c1fb2be7c6a7646bd30ac4a/libdot/js/lib_preference_manager.js
[add] https://crrev.com/b30c7d12f7f908d43c1fb2be7c6a7646bd30ac4a/libdot/js/lib_preference_manager_tests.js
[modify] https://crrev.com/b30c7d12f7f908d43c1fb2be7c6a7646bd30ac4a/libdot/html/lib_test.html
[modify] https://crrev.com/b30c7d12f7f908d43c1fb2be7c6a7646bd30ac4a/libdot/js/lib_storage_local.js

Comment 9 by vapier@chromium.org, May 3 2017

Status: Fixed (was: Available)
►

Sign in to add a comment