FormsTestCase does not verify form submission |
||||||||
Issue descriptionHttpServer does not serve anything from http://printFormData, but waitForExpectedResponse and waitForTabHistoryView do not assert if condition is not fulfilled. Release block because we have no test coverage for this feature after killing KIF tests.
,
Feb 4 2017
Too late to block beta :)
,
Feb 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59a7ad896fbc906833b38120fc8776a368fe28d2 commit 59a7ad896fbc906833b38120fc8776a368fe28d2 Author: michaeldo <michaeldo@chromium.org> Date: Wed Feb 15 16:03:14 2017 Verify FormsTestCase forms submission result. Add a missing GREYAssert to the |waitWithTimeout:| calls in |waitForExpectedResponse:| and |waitForTabHistoryView|. Fix silently failing tests (due to previously missing asserts) by implementing /printformdata page to display the request method and body. BUG= 685439 Review-Url: https://codereview.chromium.org/2690853008 Cr-Commit-Position: refs/heads/master@{#450717} [modify] https://crrev.com/59a7ad896fbc906833b38120fc8776a368fe28d2/ios/chrome/browser/web/forms_egtest.mm
,
Feb 15 2017
,
Feb 15 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-57; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-57 label, otherwise remove Merge-TBD label. Thanks.
,
Feb 22 2017
,
Feb 22 2017
This bug requires manual review: Less than 16 days to go before AppStore submit on M57 Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 23 2017
,
Feb 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8f03da2948620b7b3b946b5abd637e38734586b commit f8f03da2948620b7b3b946b5abd637e38734586b Author: Mike Dougherty <michaeldo@chromium.org> Date: Fri Feb 24 23:05:02 2017 Verify FormsTestCase forms submission result. Add a missing GREYAssert to the |waitWithTimeout:| calls in |waitForExpectedResponse:| and |waitForTabHistoryView|. Fix silently failing tests (due to previously missing asserts) by implementing /printformdata page to display the request method and body. BUG= 685439 Review-Url: https://codereview.chromium.org/2690853008 Cr-Commit-Position: refs/heads/master@{#450717} (cherry picked from commit 59a7ad896fbc906833b38120fc8776a368fe28d2) Review-Url: https://codereview.chromium.org/2716713004 . Cr-Commit-Position: refs/branch-heads/2987@{#684} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/f8f03da2948620b7b3b946b5abd637e38734586b/ios/chrome/browser/web/forms_egtest.mm |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by eugene...@chromium.org
, Feb 4 2017