Entry in reverse order for publish release DEPS |
||||
Issue descriptionThere is bug in the our recursedeps handling (we should not sort list/tuple if it is listed under recursedeps) when we do branching/patch updating. For example, https://chromium.googlesource.com/chromium/src/+/57.0.2987.10/DEPS#1142, [ 'DEPS.chromium', 'src/third_party/angle' ] should be: [ 'src/third_party/angle', 'DEPS.chromium' ]
,
Jan 26 2017
Given that the DEPS files have been like this for a long time, unless this is suddenly failing in new and different ways, I'd be inclined to fix it as part of the new "gclient --flatten" handling, which should address this and a lot of other awkward syntax handling.
,
Jan 26 2017
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/812462026ff3cd0afa6aac9b3ab3bf781a96b5b0 commit 812462026ff3cd0afa6aac9b3ab3bf781a96b5b0 Author: Aleksandr Derbenev <alex-ac@yandex-team.ru> Date: Fri Feb 10 18:10:11 2017 Make an error on wrong recursedeps entry. BUG= 685433 Change-Id: I5eb68c4a3bfd1c93edecf33127a459822f5a23ed Reviewed-on: https://chromium-review.googlesource.com/440945 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/812462026ff3cd0afa6aac9b3ab3bf781a96b5b0/gclient.py
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/b1550ec8b36f49eb67f41ed8e4582aedd1e0ade7 commit b1550ec8b36f49eb67f41ed8e4582aedd1e0ade7 Author: Dirk Pranke <dpranke@chromium.org> Date: Fri Feb 10 19:04:39 2017 Revert "Make an error on wrong recursedeps entry." This reverts commit 812462026ff3cd0afa6aac9b3ab3bf781a96b5b0. Reason for revert: This doesn't work for deps_os Original change's description: > Make an error on wrong recursedeps entry. > > BUG= 685433 > > Change-Id: I5eb68c4a3bfd1c93edecf33127a459822f5a23ed > Reviewed-on: https://chromium-review.googlesource.com/440945 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@chromium.org> > TBR=dpranke@chromium.org,caseq@chromium.org,chromium-reviews@chromium.org,alex-ac@yandex-team.ru NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 685433 Change-Id: If10b57d77dbff36d140f842d375682a20d69db06 Reviewed-on: https://chromium-review.googlesource.com/440491 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> [modify] https://crrev.com/b1550ec8b36f49eb67f41ed8e4582aedd1e0ade7/gclient.py
,
Mar 31 2017
,
Apr 25 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/release/scripts/+/8f309b0026d067da5eb00d96f6b2f5ddf2baa8a0 commit 8f309b0026d067da5eb00d96f6b2f5ddf2baa8a0 Author: dimu <dimu@google.com> Date: Tue Apr 25 23:29:37 2017
,
Apr 26 2017
It has been fixed in latest canary https://chromium.googlesource.com/chromium/src/+/60.0.3081.0/DEPS
,
Apr 26 2017
Can you change gclient behavior to prevent this bug in future? Now gclient ignores this error.
,
Apr 26 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dimu@chromium.org
, Jan 26 2017