New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685430 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

chromeos-base/libbrillo does not build with llvm-next

Project Member Reported by manojgupta@chromium.org, Jan 25 2017

Issue description

https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/llvm_next_toolchain/builds/83/steps/UnitTest/logs/stdio

libbrillo-0.0.1-r364: FAILED: obj/libbrillo/brillo/message_loops/libbrillo-395517_unittests.message_loop_unittest.o 
libbrillo-0.0.1-r364: x86_64-cros-linux-gnu-clang++ -MMD -MF obj/libbrillo/brillo/message_loops/libbrillo-395517_unittests.message_loop_unittest.o.d -DUSE_DBUS=1 -DUSE_RTTI_FOR_TYPE_TAGS -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Iobj/libbrillo/libbrillo-395517_unittests.gen/include -Igen/include -I/build/chell/tmp/portage/chromeos-base/libbrillo-0.0.1-r364/work/libbrillo-0.0.1/platform2 -I/build/chell/tmp/portage/chromeos-base/libbrillo-0.0.1-r364/work/libbrillo-0.0.1/platform -I../../../../../../../tmp/portage/chromeos-base/libbrillo-0.0.1-r364/work/libbrillo-0.0.1/platform2/libbrillo -I/build/chell/usr/include -Wall -Wno-psabi -ggdb3 -fstack-protector-strong -Wformat=2 -fvisibility=internal -Wa,--noexecstack -Werror --sysroot=/build/chell -Wno-format-zero-length -Wno-c++11-extensions -Wno-unused-local-typedefs -DBASE_VER=395517 -Wno-c++11-extensions -Wno-unused-local-typedefs -DBASE_VER=395517 -pthread -I/build/chell/usr/include/base-395517 -I/build/chell/usr/include/nss -I/build/chell/usr/include/nspr -I/build/chell/usr/include/base-test-395517 -I/build/chell/usr/include/chromeos -I/build/chell/usr/include/dbus-1.0 -I/build/chell/usr/lib64/dbus-1.0/include -I/build/chell/usr/include/glib-2.0 -I/build/chell/usr/lib64/glib-2.0/include -fPIE -std=gnu++11 -DVCSID='"0.0.1-r364-cd83e0ef6307af86d24fa2aef444739daee30058"' -DNDEBUG -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -O2 -pipe -O2 -pipe -O2 -pipe -march=corei7 -g -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -clang-syntax -clang-syntax -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables  -c ../../../../../../../tmp/portage/chromeos-base/libbrillo-0.0.1-r364/work/libbrillo-0.0.1/platform2/libbrillo/brillo/message_loops/message_loop_unittest.cc -o obj/libbrillo/brillo/message_loops/libbrillo-395517_unittests.message_loop_unittest.o
libbrillo-0.0.1-r364: ../../../../../../../tmp/portage/chromeos-base/libbrillo-0.0.1-r364/work/libbrillo-0.0.1/platform2/libbrillo/brillo/message_loops/message_loop_unittest.cc:285:21: error: lambda capture 'kNumTasks' is not required to be captured for use in an unevaluated context [-Werror,-Wunused-lambda-capture]
libbrillo-0.0.1-r364:         Bind([this, kNumTasks, &task_ids] {
libbrillo-0.0.1-r364:                     ^
libbrillo-0.0.1-r364: ../../../../../../../usr/include/gtest/internal/gtest-internal.h:454:43: note: in instantiation of member function 'brillo::MessageLoopTest_DeleteAllPersistenIOTaskFromSelf_Test<brillo::BaseMessageLoop>::TestBody' requested here
libbrillo-0.0.1-r364:   virtual Test* CreateTest() { return new TestClass; }
libbrillo-0.0.1-r364:                                           ^
libbrillo-0.0.1-r364: ../../../../../../../usr/include/gtest/internal/gtest-internal.h:589:13: note: in instantiation of member function 'testing::internal::TestFactoryImpl<brillo::MessageLoopTest_DeleteAllPersistenIOTaskFromSelf_Test<brillo::BaseMessageLoop> >::CreateTest' requested here
libbrillo-0.0.1-r364:         new TestFactoryImpl<TestClass>);
libbrillo-0.0.1-r364:             ^
libbrillo-0.0.1-r364: ../../../../../../../usr/include/gtest/internal/gtest-internal.h:593:11: note: in instantiation of member function 'testing::internal::TypeParameterizedTest<MessageLoopTest, testing::internal::TemplateSel<MessageLoopTest_DeleteAllPersistenIOTaskFromSelf_Test>, testing::internal::Types1<brillo::BaseMessageLoop> >::Register' requested here
libbrillo-0.0.1-r364:         ::Register(prefix, case_name, test_names, index + 1);
libbrillo-0.0.1-r364:           ^
libbrillo-0.0.1-r364: ../../../../../../../tmp/portage/chromeos-base/libbrillo-0.0.1-r364/work/libbrillo-0.0.1/platform2/libbrillo/brillo/message_loops/message_loop_unittest.cc:276:1: note: in instantiation of member function 'testing::internal::TypeParameterizedTest<MessageLoopTest, testing::internal::TemplateSel<MessageLoopTest_DeleteAllPersistenIOTaskFromSelf_Test>, testing::internal::Types2<brillo::GlibMessageLoop, brillo::BaseMessageLoop> >::Register' requested here
libbrillo-0.0.1-r364: TYPED_TEST(MessageLoopTest, DeleteAllPersistenIOTaskFromSelf) {
libbrillo-0.0.1-r364: ^
libbrillo-0.0.1-r364: ../../../../../../../usr/include/gtest/gtest-typed-test.h:183:42: note: expanded from macro 'TYPED_TEST'
libbrillo-0.0.1-r364:           GTEST_TYPE_PARAMS_(CaseName)>::Register(\
libbrillo-0.0.1-r364:                                          ^
libbrillo-0.0.1-r364: ../../../../../../../tmp/portage/chromeos-base/libbrillo-0.0.1-r364/work/libbrillo-0.0.1/platform2/libbrillo/brillo/message_loops/message_loop_unittest.cc:285:21: error: lambda capture 'kNumTasks' is not required to be captured for use in an unevaluated context [-Werror,-Wunused-lambda-capture]
libbrillo-0.0.1-r364:         Bind([this, kNumTasks, &task_ids] {
libbrillo-0.0.1-r364:                     ^
libbrillo-0.0.1-r364: ../../../../../../../usr/include/gtest/internal/gtest-internal.h:454:43: note: in instantiation of member function 'brillo::MessageLoopTest_DeleteAllPersistenIOTaskFromSelf_Test<brillo::GlibMessageLoop>::TestBody' requested here
libbrillo-0.0.1-r364:   virtual Test* CreateTest() { return new TestClass; }
libbrillo-0.0.1-r364:                                           ^
libbrillo-0.0.1-r364: ../../../../../../../usr/include/gtest/internal/gtest-internal.h:589:13: note: in instantiation of member function 'testing::internal::TestFactoryImpl<brillo::MessageLoopTest_DeleteAllPersistenIOTaskFromSelf_Test<brillo::GlibMessageLoop> >::CreateTest' requested here
libbrillo-0.0.1-r364:         new TestFactoryImpl<TestClass>);
libbrillo-0.0.1-r364:             ^
libbrillo-0.0.1-r364: ../../../../../../../tmp/portage/chromeos-base/libbrillo-0.0.1-r364/work/libbrillo-0.0.1/platform2/libbrillo/brillo/message_loops/message_loop_unittest.cc:276:1: note: in instantiation of member function 'testing::internal::TypeParameterizedTest<MessageLoopTest, testing::internal::TemplateSel<MessageLoopTest_DeleteAllPersistenIOTaskFromSelf_Test>, testing::internal::Types2<brillo::GlibMessageLoop, brillo::BaseMessageLoop> >::Register' requested here
libbrillo-0.0.1-r364: TYPED_TEST(MessageLoopTest, DeleteAllPersistenIOTaskFromSelf) {
libbrillo-0.0.1-r364: ^
libbrillo-0.0.1-r364: ../../../../../../../usr/include/gtest/gtest-typed-test.h:183:42: note: expanded from macro 'TYPED_TEST'
libbrillo-0.0.1-r364:           GTEST_TYPE_PARAMS_(CaseName)>::Register(\
libbrillo-0.0.1-r364:                                          ^
libbrillo-0.0.1-r364: 2 errors generated.
libbrillo-0.0.1-r364: 
libbrillo-0.0.1-r364: [146/147] CXX obj/libbrillo/brillo/http/libbrillo-395517_unittests.http_request_unittest.o
libbrillo-0.0.1-r364: FAILED: obj/libbrillo/brillo/http/libbrillo-395517_unittests.http_request_unittest.o 
libbrillo-0.0.1-r364: x86_64-cros-linux-gnu-clang++ -MMD -MF obj/libbrillo/brillo/http/libbrillo-395517_unittests.http_request_unittest.o.d -DUSE_DBUS=1 -DUSE_RTTI_FOR_TYPE_TAGS -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Iobj/libbrillo/libbrillo-395517_unittests.gen/include -Igen/include -I/build/chell/tmp/portage/chromeos-base/libbrillo-0.0.1-r364/work/libbrillo-0.0.1/platform2 -I/build/chell/tmp/portage/chromeos-base/libbrillo-0.0.1-r364/work/libbrillo-0.0.1/platform -I../../../../../../../tmp/portage/chromeos-base/libbrillo-0.0.1-r364/work/libbrillo-0.0.1/platform2/libbrillo -I/build/chell/usr/include -Wall -Wno-psabi -ggdb3 -fstack-protector-strong -Wformat=2 -fvisibility=internal -Wa,--noexecstack -Werror --sysroot=/build/chell -Wno-format-zero-length -Wno-c++11-extensions -Wno-unused-local-typedefs -DBASE_VER=395517 -Wno-c++11-extensions -Wno-unused-local-typedefs -DBASE_VER=395517 -pthread -I/build/chell/usr/include/base-395517 -I/build/chell/usr/include/nss -I/build/chell/usr/include/nspr -I/build/chell/usr/include/base-test-395517 -I/build/chell/usr/include/chromeos -I/build/chell/usr/include/dbus-1.0 -I/build/chell/usr/lib64/dbus-1.0/include -I/build/chell/usr/include/glib-2.0 -I/build/chell/usr/lib64/glib-2.0/include -fPIE -std=gnu++11 -DVCSID='"0.0.1-r364-cd83e0ef6307af86d24fa2aef444739daee30058"' -DNDEBUG -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -O2 -pipe -O2 -pipe -O2 -pipe -march=corei7 -g -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -clang-syntax -clang-syntax -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables  -c ../../../../../../../tmp/portage/chromeos-base/libbrillo-0.0.1-r364/work/libbrillo-0.0.1/platform2/libbrillo/brillo/http/http_request_unittest.cc -o obj/libbrillo/brillo/http/libbrillo-395517_unittests.http_request_unittest.o
libbrillo-0.0.1-r364: ../../../../../../../tmp/portage/chromeos-base/libbrillo-0.0.1-r364/work/libbrillo-0.0.1/platform2/libbrillo/brillo/http/http_request_unittest.cc:178:27: error: lambda capture 'resp_data' is not used [-Werror,-Wunused-lambda-capture]
libbrillo-0.0.1-r364:       [this, &read_data, &resp_data](const SuccessCallback& success_callback) {
libbrillo-0.0.1-r364:                           ^
libbrillo-0.0.1-r364: 1 error generated.
libbrillo-0.0.1-r364: ninja: build stopped: subcommand failed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/external/libbrillo/+/e2743693963e3e5d79bb44951eb9cbc1a99233a1

commit e2743693963e3e5d79bb44951eb9cbc1a99233a1
Author: Manoj Gupta <manojgupta@google.com>
Date: Thu Jan 26 09:52:10 2017

Fix libbrillo warnings to make it build with llvm-next on chromeos.

Fix the warnings [-Wunused-lambda-capture] in libbrillo.

Bug= chromium:685430 
TEST=libbrillo compiles

Change-Id: Icb01a91f37b955cdf1e7beb93301951bd8385537
Reviewed-on: https://chromium-review.googlesource.com/433339
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: Alex Deymo <deymo@chromium.org>
Reviewed-by: Alex Vakulenko <avakulenko@chromium.org>

[modify] https://crrev.com/e2743693963e3e5d79bb44951eb9cbc1a99233a1/brillo/message_loops/message_loop_unittest.cc
[modify] https://crrev.com/e2743693963e3e5d79bb44951eb9cbc1a99233a1/brillo/http/http_request_unittest.cc

Status: Fixed (was: Untriaged)
Status: Verified (was: Fixed)

Sign in to add a comment