New issue
Advanced search Search tips

Issue 685427 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Disable MD oobe by default in m57

Project Member Reported by jdufault@chromium.org, Jan 25 2017

Issue description

Disable MD oobe by default in m57
 
Labels: Merge-Request-57
Patch is very simple and targeted at m57 only.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/754b87823adee6b7e9842596749342cd23767e41

commit 754b87823adee6b7e9842596749342cd23767e41
Author: jdufault <jdufault@chromium.org>
Date: Thu Jan 26 06:30:37 2017

cros: Disable md oobe by default in m57.

BUG= 685427 

Review-Url: https://codereview.chromium.org/2654173003
Cr-Commit-Position: refs/heads/master@{#446253}

[modify] https://crrev.com/754b87823adee6b7e9842596749342cd23767e41/chrome/browser/chromeos/login/wizard_controller.cc

Comment 4 by gov...@chromium.org, Jan 26 2017

Labels: OS-Chrome
Seems like this is specific to Chrome OS.
Labels: -Merge-Request-57 Merge-Approved-57
Approved for merge to m57 Chrome OS.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 26 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4773fe14a1438c115b590fae7fae57e194d277e5

commit 4773fe14a1438c115b590fae7fae57e194d277e5
Author: Jacob Dufault <jdufault@google.com>
Date: Thu Jan 26 19:35:32 2017

cros: Disable md oobe by default in m57.

BUG= 685427 

Review-Url: https://codereview.chromium.org/2654173003
Cr-Commit-Position: refs/heads/master@{#446253}
(cherry picked from commit 754b87823adee6b7e9842596749342cd23767e41)

Review-Url: https://codereview.chromium.org/2651293004 .
Cr-Commit-Position: refs/branch-heads/2987@{#114}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/4773fe14a1438c115b590fae7fae57e194d277e5/chrome/browser/chromeos/login/wizard_controller.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/634e008ce4bc97d0a1d83d979ab130887b98328e

commit 634e008ce4bc97d0a1d83d979ab130887b98328e
Author: jdufault <jdufault@chromium.org>
Date: Thu Jan 26 20:03:28 2017

Revert of cros: Disable md oobe by default in m57. (patchset #1 id:20001 of https://codereview.chromium.org/2654173003/ )

Reason for revert:
Not meant to land in master

Original issue's description:
> cros: Disable md oobe by default in m57.
>
> BUG= 685427 
>
> Review-Url: https://codereview.chromium.org/2654173003
> Cr-Commit-Position: refs/heads/master@{#446253}
> Committed: https://chromium.googlesource.com/chromium/src/+/754b87823adee6b7e9842596749342cd23767e41

TBR=achuith@chromium.org,steel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 685427 

Review-Url: https://codereview.chromium.org/2654393002
Cr-Commit-Position: refs/heads/master@{#446415}

[modify] https://crrev.com/634e008ce4bc97d0a1d83d979ab130887b98328e/chrome/browser/chromeos/login/wizard_controller.cc

Status: Fixed (was: Started)

Comment 9 by st...@chromium.org, Mar 3 2017

Cc: r...@chromium.org
Cc: -st...@chromium.org

Comment 11 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 12 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 14 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment