New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 685426 link

Starred by 1 user
Status: Fixed
Owner:
█ xlai@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Cc:
█ fsam...@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Mac
Pri: 3
Type: Bug

Blocking:
issue 674744



Sign in to add a comment

FrameSinkId for DelegatedFrameHost creation in Android/Mac need to be changed

Project Member Reported by xlai@chromium.org, Jan 25 2017 
Currently, the DelegatedFrameHost created in render widget aura handle the case when GuestViews have two RenderWidgetHostViews (which might have FrameSinkId collision). But 
the same handling is done properly done on Android and Mac. We need to fix that.

Comment 1 by xlai@chromium.org, Jan 25 2017

Blocking: 674744
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9351829f20da199ef48bc3aaaa70f2172baab179

commit 9351829f20da199ef48bc3aaaa70f2172baab179
Author: xlai <xlai@chromium.org>
Date: Fri Jan 27 18:39:13 2017

Let DelegateFrameHost in Mac and Android use correct FrameSinkId during creation

BUG= 685426 

Review-Url: https://codereview.chromium.org/2656893003
Cr-Commit-Position: refs/heads/master@{#446720}

[modify] https://crrev.com/9351829f20da199ef48bc3aaaa70f2172baab179/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/9351829f20da199ef48bc3aaaa70f2172baab179/content/browser/renderer_host/browser_compositor_view_mac.h
[modify] https://crrev.com/9351829f20da199ef48bc3aaaa70f2172baab179/content/browser/renderer_host/browser_compositor_view_mac.mm
[modify] https://crrev.com/9351829f20da199ef48bc3aaaa70f2172baab179/content/browser/renderer_host/context_provider_factory_impl_android.cc
[modify] https://crrev.com/9351829f20da199ef48bc3aaaa70f2172baab179/content/browser/renderer_host/context_provider_factory_impl_android.h
[modify] https://crrev.com/9351829f20da199ef48bc3aaaa70f2172baab179/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/9351829f20da199ef48bc3aaaa70f2172baab179/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/9351829f20da199ef48bc3aaaa70f2172baab179/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/9351829f20da199ef48bc3aaaa70f2172baab179/ui/android/delegated_frame_host_android.cc
[modify] https://crrev.com/9351829f20da199ef48bc3aaaa70f2172baab179/ui/android/delegated_frame_host_android.h
[modify] https://crrev.com/9351829f20da199ef48bc3aaaa70f2172baab179/ui/compositor/test/in_process_context_factory.cc
[modify] https://crrev.com/9351829f20da199ef48bc3aaaa70f2172baab179/ui/compositor/test/in_process_context_factory.h

Comment 3 by xlai@chromium.org, Jan 31 2017

Status: Fixed (was: Assigned)

Comment 4 by lafo...@chromium.org, Feb 26 2018

Components: -MUS Internals>Services>WindowService
►

Sign in to add a comment