New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 685412 link

Starred by 1 user
Status: Fixed
Owner:
█ baxley@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

ShellBaseTestCase should fail when it looks for webview with "Chromium" after first test case

Project Member Reported by baxley@chromium.org, Jan 25 2017 
The base class setup verifies the webview contains "Chromium". However, it passes when this isn't the case.

Additionally the placement of this assertion is problematic, since it will fail the test causing the http server to not be started, which results in a DCHECK in test teardown.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3432563dba5d8feb7819262688a0741a66c6bf35

commit 3432563dba5d8feb7819262688a0741a66c6bf35
Author: baxley <baxley@chromium.org>
Date: Wed Feb 01 21:20:41 2017

Update web shell app to not load dev.chromium.org on launch.

Loading this can delay tests that typically use the fake HTTP
server. This includes a few synchronization fixes when loading
URLs.

BUG= 685412 

Review-Url: https://codereview.chromium.org/2665423002
Cr-Commit-Position: refs/heads/master@{#447611}

[modify] https://crrev.com/3432563dba5d8feb7819262688a0741a66c6bf35/ios/web/shell/test/earl_grey/shell_base_test_case.mm
[modify] https://crrev.com/3432563dba5d8feb7819262688a0741a66c6bf35/ios/web/shell/test/earl_grey/shell_earl_grey.mm
[modify] https://crrev.com/3432563dba5d8feb7819262688a0741a66c6bf35/ios/web/shell/view_controller.mm

Comment 2 by baxley@chromium.org, Feb 2 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment