Complain less about inability to install every single site if Add to Shelf is enabled |
||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36 Steps to reproduce the problem: 1. Turn on chrome://flags/#enable-add-to-shelf 2. Visit a localhost site (served over http) - extremely common in development 3. Look in the console for the error message "Site cannot be installed: the page is not served from a secure origin" 4. Navigate to https://stackoverflow.com/questions/41863050/why-does-chrome-keep-displaying-site-cannot-be-installed-the-page-is-not-serve/ 5. Look in the console for the error message "Site cannot be installed: the page has no manifest <link> URL" 6. Go to an HTTPS site you've never visited before, such as https://www.random.org/integers/ and notice the same complain about the manifest. What is the expected behavior? No error messages, and certainly no messages on the first visit to a site, before the A2HS heuristics have been met. What went wrong? Site cannot be installed: the page is not served from a secure origin Site cannot be installed: the page has no manifest <link> URL Did this work before? N/A Chrome version: 55.0.2883.87 Channel: stable OS Version: Flash Version: The vast majority of sites don't have a manifests, so it makes little sense to display those error messages on any random web site. On the other hand, they should be displayed when the developer is specifically working on A2HS functionality, and there should be mechanisms for allowing the error on demand, or suppressing further displays of the error.
,
Feb 13 2017
Thanks for the report. I'm not sure where best to direct this, but there's relevant commits around banners/install logging by dominickn@. dominickn@, could you please take a look?
,
Feb 14 2017
These error messages are only displayed if chrome://flags/#bypass-app-banner-engagement-checks is enabled, which forces banners to display and logs console messages if they can't. Can you please verify if you see the messages *AND* that flag is not enabled.
,
Feb 14 2017
If the flag is disabled, I don't see the messages.
,
Feb 14 2017
Thanks, this is working as intended. : ) |
||||
►
Sign in to add a comment |
||||
Comment 1 by ajha@chromium.org
, Jan 31 2017