https://build.chromium.org/p/chromium.gpu/builders/GPU%20Mac%20Builder/builds/81497
I'm suspecting: https://codereview.chromium.org/2629433003/
Reverted here: https://codereview.chromium.org/2655533005/
From compile log:
FAILED: obj/services/shape_detection/lib/face_detection_impl_mac.o
export DEVELOPER_DIR=/b/c/b/mac/src/build/mac_files/Xcode.app; /b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/services/shape_detection/lib/face_detection_impl_mac.o.d -DV8_DEPRECATION_WARNINGS -DDCHECK_ALWAYS_ON=1 -DNO_TCMALLOC -DUSE_EXTERNAL_POPUP_MENU=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=289944-2 -DCR_XCODE_VERSION=0511 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DENABLE_IPC_FUZZER -DSK_IGNORE_DW_GRAY_FIX -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_SUPPORT_GPU=1 -DSK_BUILD_FOR_MAC -I../.. -Igen -I../../third_party/khronos -I../../gpu -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -arch x86_64 -Wall -Werror -Wextra -Wpartial-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -O2 -g1 -isysroot /b/c/b/mac/src/build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -mmacosx-version-min=10.9 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -fno-threadsafe-statics -fvisibility-inlines-hidden -std=c++11 -stdlib=libc++ -fobjc-call-cxx-cdtors -Wobjc-missing-property-synthesis -fno-rtti -fno-exceptions -c ../../services/shape_detection/face_detection_impl_mac.mm -o obj/services/shape_detection/lib/face_detection_impl_mac.o
In file included from ../../services/shape_detection/face_detection_impl_mac.mm:5:
../../services/shape_detection/face_detection_impl_mac.h:24:29: error: non-virtual member function marked 'override' hides virtual member function
callback) override;
^
gen/services/shape_detection/public/interfaces/facedetection.mojom.h:105:16: note: hidden overloaded virtual function 'shape_detection::mojom::FaceDetection::Detect' declared here: different number of parameters (2 vs 4)
virtual void Detect(const SkBitmap& bitmap_data, const DetectCallback& callback) = 0;
^
In file included from ../../services/shape_detection/face_detection_impl_mac.mm:5:
In file included from ../../services/shape_detection/face_detection_impl_mac.h:11:
In file included from gen/services/shape_detection/public/interfaces/facedetection.mojom.h:16:
In file included from ../../mojo/public/cpp/bindings/associated_interface_ptr.h:19:
In file included from ../../mojo/public/cpp/bindings/associated_group.h:12:
In file included from ../../mojo/public/cpp/bindings/associated_interface_request.h:12:
../../base/memory/ptr_util.h:56:33: error: allocating an object of abstract class type 'shape_detection::FaceDetectionImplMac'
return std::unique_ptr<T>(new T(std::forward<Args>(args)...));
^
../../services/shape_detection/face_detection_impl_mac.mm:43:13: note: in instantiation of function template specialization 'base::MakeUnique<shape_detection::FaceDetectionImplMac, mojo::InlinedStructPtr<shape_detection::mojom::FaceDetectorOptions> >' requested here
base::MakeUnique<FaceDetectionImplMac>(std::move(options)),
^
gen/services/shape_detection/public/interfaces/facedetection.mojom.h:105:16: note: unimplemented pure virtual method 'Detect' in 'FaceDetectionImplMac'
virtual void Detect(const SkBitmap& bitmap_data, const DetectCallback& callback) = 0;
^
2 errors generated.
Comment 1 by manisca...@chromium.org
, Jan 25 2017Status: Assigned (was: Untriaged)