Some of our tests use /deep/ and :shadow selectors. Some of our components use ::content to style the light dom.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66019590aaaba940c5fdd563f3e0c901122727d5 commit 66019590aaaba940c5fdd563f3e0c901122727d5 Author: einbinder <einbinder@chromium.org> Date: Fri Jan 27 03:06:04 2017 DevTools: Move checkbox title element into Shadow DOM BUG=685385 Review-Url: https://codereview.chromium.org/2656823004 Cr-Commit-Position: refs/heads/master@{#446559} [modify] https://crrev.com/66019590aaaba940c5fdd563f3e0c901122727d5/third_party/WebKit/LayoutTests/inspector/extensions/extensions-audits-tests.js [modify] https://crrev.com/66019590aaaba940c5fdd563f3e0c901122727d5/third_party/WebKit/Source/devtools/front_end/components/breakpointsList.css [modify] https://crrev.com/66019590aaaba940c5fdd563f3e0c901122727d5/third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js [modify] https://crrev.com/66019590aaaba940c5fdd563f3e0c901122727d5/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js [modify] https://crrev.com/66019590aaaba940c5fdd563f3e0c901122727d5/third_party/WebKit/Source/devtools/front_end/ui/checkboxTextLabel.css
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b115a08ad32ae5beda325c98ba50446b7e034eab commit b115a08ad32ae5beda325c98ba50446b7e034eab Author: einbinder <einbinder@chromium.org> Date: Fri Jan 27 05:59:07 2017 DevTools: Move radio button input element into Shadow DOM BUG=685385 Review-Url: https://codereview.chromium.org/2650213005 Cr-Commit-Position: refs/heads/master@{#446606} [modify] https://crrev.com/b115a08ad32ae5beda325c98ba50446b7e034eab/third_party/WebKit/Source/devtools/front_end/network/networkConfigView.css [modify] https://crrev.com/b115a08ad32ae5beda325c98ba50446b7e034eab/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js [modify] https://crrev.com/b115a08ad32ae5beda325c98ba50446b7e034eab/third_party/WebKit/Source/devtools/front_end/ui/radioButton.css
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50ae54449909cd460dfa06eb4bcef261363e8cb4 commit 50ae54449909cd460dfa06eb4bcef261363e8cb4 Author: einbinder <einbinder@chromium.org> Date: Sat Jan 28 00:18:16 2017 Revert of DevTools: Move radio button input element into Shadow DOM (patchset #1 id:1 of https://codereview.chromium.org/2650213005/ ) Reason for revert: Breaks all the radio buttons Original issue's description: > DevTools: Move radio button input element into Shadow DOM > > BUG=685385 > > Review-Url: https://codereview.chromium.org/2650213005 > Cr-Commit-Position: refs/heads/master@{#446606} > Committed: https://chromium.googlesource.com/chromium/src/+/b115a08ad32ae5beda325c98ba50446b7e034eab TBR=dgozman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=685385 Review-Url: https://codereview.chromium.org/2661623003 Cr-Commit-Position: refs/heads/master@{#446843} [modify] https://crrev.com/50ae54449909cd460dfa06eb4bcef261363e8cb4/third_party/WebKit/Source/devtools/front_end/network/networkConfigView.css [modify] https://crrev.com/50ae54449909cd460dfa06eb4bcef261363e8cb4/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js [modify] https://crrev.com/50ae54449909cd460dfa06eb4bcef261363e8cb4/third_party/WebKit/Source/devtools/front_end/ui/radioButton.css
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b33179f30890438ffd64fcc6258f47ba65cf2378 commit b33179f30890438ffd64fcc6258f47ba65cf2378 Author: luoe <luoe@chromium.org> Date: Sat Jan 28 00:34:08 2017 DevTools: remove deprecated shadow dom selectors from inspector LayoutTests BUG=685385 Review-Url: https://codereview.chromium.org/2658723005 Cr-Commit-Position: refs/heads/master@{#446850} [modify] https://crrev.com/b33179f30890438ffd64fcc6258f47ba65cf2378/third_party/WebKit/LayoutTests/http/tests/inspector/network/preview-searchable.html [modify] https://crrev.com/b33179f30890438ffd64fcc6258f47ba65cf2378/third_party/WebKit/LayoutTests/inspector/console/console-custom-formatters.html [modify] https://crrev.com/b33179f30890438ffd64fcc6258f47ba65cf2378/third_party/WebKit/LayoutTests/inspector/console/console-edit-property-value.html [modify] https://crrev.com/b33179f30890438ffd64fcc6258f47ba65cf2378/third_party/WebKit/LayoutTests/inspector/console/console-search.html
Here's my analysis of SDv0 / CEv0 API usage in devtools: https://docs.google.com/document/d/1sOkgQvbmSIM_jRd9joFXPqtywZALHFp6FFrLkwHwIXo/edit Here's my attempt to convert not all of them: https://chromium-review.googlesource.com/c/chromium/src/+/1027450
For the reference, here's another attempt converting just the custom element registration for now: https://chromium-review.googlesource.com/c/chromium/src/+/1344139
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d828088b0546192c7cb08fd8404ead6422e39cdf commit d828088b0546192c7cb08fd8404ead6422e39cdf Author: Joel Einbinder <einbinder@chromium.org> Date: Sat Dec 08 01:01:37 2018 DevTools: Shadow DOM v0 polyfill This polyfills Shadow DOM v0 on top of Shadow DOM v1 for old devtools front ends. Bug: 685385 Change-Id: Ia2a79a86012cbec2fc7cff3cb36fe4c9b631a381 Reviewed-on: https://chromium-review.googlesource.com/c/1366325 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#614893} [modify] https://crrev.com/d828088b0546192c7cb08fd8404ead6422e39cdf/third_party/blink/renderer/devtools/front_end/devtools_compatibility.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64e9bfb30b51952e956210ce1c60a6b69e2b405f commit 64e9bfb30b51952e956210ce1c60a6b69e2b405f Author: Joel Einbinder <einbinder@chromium.org> Date: Wed Dec 12 02:01:12 2018 DevTools: Polyfill Custom Elements V0 for old frontends Bug: 685385 Change-Id: I1adae3ac86a2af361b1253f7e723aa86a7ce397e Reviewed-on: https://chromium-review.googlesource.com/c/1371086 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#615780} [modify] https://crrev.com/64e9bfb30b51952e956210ce1c60a6b69e2b405f/third_party/blink/renderer/devtools/front_end/devtools_compatibility.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b7dcc04c0e3e466073905f9c8e9f088798438f8 commit 2b7dcc04c0e3e466073905f9c8e9f088798438f8 Author: Joel Einbinder <einbinder@chromium.org> Date: Fri Jan 18 02:01:18 2019 DevTools: Remove ShadowDOM from TextPrompt The previous text prompt implementation relied heavily on ::content. Bug: 685385 Change-Id: I20a2b4aa098e17e8b940ad4048e36ce7b5017551 Reviewed-on: https://chromium-review.googlesource.com/c/1410873 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#623954} [modify] https://crrev.com/2b7dcc04c0e3e466073905f9c8e9f088798438f8/third_party/blink/renderer/devtools/front_end/elements_test_runner/ElementsTestRunner.js [modify] https://crrev.com/2b7dcc04c0e3e466073905f9c8e9f088798438f8/third_party/blink/renderer/devtools/front_end/ui/TextPrompt.js [modify] https://crrev.com/2b7dcc04c0e3e466073905f9c8e9f088798438f8/third_party/blink/renderer/devtools/front_end/ui/textPrompt.css [modify] https://crrev.com/2b7dcc04c0e3e466073905f9c8e9f088798438f8/third_party/blink/web_tests/http/tests/devtools/elements/styles/styles-mouse-test.js [modify] https://crrev.com/2b7dcc04c0e3e466073905f9c8e9f088798438f8/third_party/blink/web_tests/http/tests/devtools/elements/styles/up-down-numerics-and-colors.js [modify] https://crrev.com/2b7dcc04c0e3e466073905f9c8e9f088798438f8/third_party/blink/web_tests/http/tests/devtools/unit/text-prompt-hint.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d58585ed08d92f075d39ea9e684fe78777700940 commit d58585ed08d92f075d39ea9e684fe78777700940 Author: Joel Einbinder <einbinder@chromium.org> Date: Fri Jan 18 02:28:46 2019 DevTools: Remove ShadowDOM from text-button With ShadowDOM v1, shadow roots can no longer be attached to buttons. Bug: 685385 Change-Id: I57500c976fb3b31c43344dcaeef2140b93a38b80 Reviewed-on: https://chromium-review.googlesource.com/c/1413356 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#623963} [modify] https://crrev.com/d58585ed08d92f075d39ea9e684fe78777700940/third_party/blink/renderer/devtools/front_end/emulation/sensors.css [modify] https://crrev.com/d58585ed08d92f075d39ea9e684fe78777700940/third_party/blink/renderer/devtools/front_end/ui/UIUtils.js [modify] https://crrev.com/d58585ed08d92f075d39ea9e684fe78777700940/third_party/blink/renderer/devtools/front_end/ui/textButton.css [modify] https://crrev.com/d58585ed08d92f075d39ea9e684fe78777700940/third_party/blink/web_tests/http/tests/devtools/security/interstitial-sidebar-expected.txt [modify] https://crrev.com/d58585ed08d92f075d39ea9e684fe78777700940/third_party/blink/web_tests/http/tests/devtools/security/origin-view-ct-compliance-expected.txt [modify] https://crrev.com/d58585ed08d92f075d39ea9e684fe78777700940/third_party/blink/web_tests/http/tests/devtools/security/origin-view-then-interstitial-expected.txt [modify] https://crrev.com/d58585ed08d92f075d39ea9e684fe78777700940/third_party/blink/web_tests/http/tests/devtools/security/security-details-updated-with-security-state-expected.txt [modify] https://crrev.com/d58585ed08d92f075d39ea9e684fe78777700940/third_party/blink/web_tests/http/tests/devtools/security/security-explanation-ordering-expected.txt
I prioritized this as P1 for next milestone.
As comment 11, DevTool doesn't use Custom Element v0 and only Shadow DOM v0 is left?
FYI, this is the patch that removes Shadow DOM V0, Custom Element V0 and HTML Imports APIs that would be shipped since M74 https://chromium-review.googlesource.com/c/chromium/src/+/1420637 As you might know, the patch that reenables the APIs for DevTools on the patch was shipped: https://chromium-review.googlesource.com/c/chromium/src/+/1362713 This is a last-resort for the removal and should be reverted. So we need both to patch 1420637 and revert 1362713 to confirm if migration works.
Comment 1 by einbinder@chromium.org
, Jan 25 2017