Should not retry wolf-tot-paladin if it passes MasterSlaveLKGMSync stage |
||||||
Issue descriptionmaster-paladin retried wolf-tot-paladin, but wolf-tot-paladin already passed its SyncStage. The reason is wolf-tot-paladin uses another sync class MasterSlaveLKGMSync, while previously we assumed all paladin would use CommitQueueSync class. "do_not_apply_cq_patches" is marked as true in wolf-tot-paladin, so MasterSlaveLKGMSyncStage is used by wolf-tot-paladin. Currently wolf-tot-paladin is the only paladin using MasterSlaveLKGMSyncStage. http://shortn/_FJlTyCbrjP Will fix the retry to cover this case.
,
Jan 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/baaf7e035d543cf3b11fc3fdbe5788d25a7df88a commit baaf7e035d543cf3b11fc3fdbe5788d25a7df88a Author: Ningning Xia <nxia@chromium.org> Date: Wed Jan 25 23:35:18 2017 Add MasterSlaveLKGMSync to the CriticalStageSet for CQ retry decisions wolf-tot-paladin uses MasterSlaveLKGMSync instead of CommitQueueSync as its sync stage. CQ-master shoudn't retry wolf-tot-paladin if it already passed its MasterSlaveLKGMSync. So need to add MasterSlaveLKGMSync to CriticalStageSet for CQ-master. Clean up some tests in build_status_unittest. BUG= chromium:685380 TEST=unit_tests Change-Id: I7ffa1e8c54a5c1a0c43fa829707d3d3058f60c2d Reviewed-on: https://chromium-review.googlesource.com/433203 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/baaf7e035d543cf3b11fc3fdbe5788d25a7df88a/cbuildbot/build_status_unittest.py [modify] https://crrev.com/baaf7e035d543cf3b11fc3fdbe5788d25a7df88a/lib/config_lib.py [modify] https://crrev.com/baaf7e035d543cf3b11fc3fdbe5788d25a7df88a/cbuildbot/build_status.py
,
Jan 30 2017
Fixed?
,
Jan 30 2017
Re #3, I believe so, will keep an eye on that.
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by nxia@chromium.org
, Jan 25 2017