New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 685379 link

Starred by 1 user
Status: Fixed
Owner:
█ jaydasika@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Cc:
weiliangc@chromium.org
ajuma@chromium.org
dtapu...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Add UMA metric to measure time spend in finding closest matching layer during hit testing

Project Member Reported by jaydasika@chromium.org, Jan 25 2017 
The logic to find the closest matching layer uses cached clips stored on the clip tree. This needs to change as the cached clips in the clip tree are being removed ( https://crbug.com/594675 ). Adding UMA metric will help us make sure there are no performance regressions because of the change
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee0ab199b6e9bd10d179fa1cfb379eff943d8b9e

commit ee0ab199b6e9bd10d179fa1cfb379eff943d8b9e
Author: jaydasika <jaydasika@chromium.org>
Date: Tue Jan 31 00:03:39 2017

cc : Add UMA metric for finding closest matching layer to a point

The logic to find the closest matching layer is going to change. Adding
a UMA metric to track performance before and after the change.

BUG= 685379 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2655853004
Cr-Commit-Position: refs/heads/master@{#447117}

[modify] https://crrev.com/ee0ab199b6e9bd10d179fa1cfb379eff943d8b9e/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/ee0ab199b6e9bd10d179fa1cfb379eff943d8b9e/tools/metrics/histograms/histograms.xml

Comment 2 by jaydasika@chromium.org, Feb 2 2017

Labels: Merge-Request-57
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 2 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 3 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/665e887dd3515599663477e67012a4d4288c1d6f

commit 665e887dd3515599663477e67012a4d4288c1d6f
Author: Jayadev Dasika <jaydasika@google.com>
Date: Fri Feb 03 20:09:57 2017

cc : Add UMA metric for finding closest matching layer to a point

The logic to find the closest matching layer is going to change. Adding
a UMA metric to track performance before and after the change.

BUG= 685379 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2655853004
Cr-Commit-Position: refs/heads/master@{#447117}
(cherry picked from commit ee0ab199b6e9bd10d179fa1cfb379eff943d8b9e)

Review-Url: https://codereview.chromium.org/2672603007 .
Cr-Commit-Position: refs/branch-heads/2987@{#298}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/665e887dd3515599663477e67012a4d4288c1d6f/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/665e887dd3515599663477e67012a4d4288c1d6f/tools/metrics/histograms/histograms.xml

Comment 5 by jaydasika@chromium.org, Feb 25 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment