Create OfflinePageService and make it own/vend the other sunservices of Offline Pages Backend |
|||
Issue descriptionWe create the same policy for everything. They should ideally be the same instance. Perhaps this should be a keyed service or some other static item
,
Feb 27 2017
Alternatively, this can be a common OfflinePageService which would vend the instances of other sub-services (model, RC, PolicyController etc). It should be cheap to create the objects themselves but avid heavy operations like database loading until it is needed. We already moved the Model API to be async so it should be relatively easy change.
,
Feb 27 2017
Changing the title and more detail: The OfflilnePageService also should take ownership and provide the objects that are currently 'attached' to Model or RequestCoordinator by means of SetUserData. See DownloadUIAdapter::FromOfflinePageModel for example.
,
Feb 28 2017
Blocker: 1-pager Need signoffs from: rest of team Estimated blocker resolution: 2-3 days
,
Aug 17
There seems to be too many things in flux for this to be a good idea right now. Since it hasn't been needed for so long, it makes sense to wait until it's necessary (i.e. when we combine databases) |
|||
►
Sign in to add a comment |
|||
Comment 1 by dim...@chromium.org
, Feb 8 2017Owner: chili@chromium.org
Status: Assigned (was: Available)