New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 685359 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
please use my google.com address
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Catalog manifest sources may exceed string constant length

Project Member Reported by roc...@chromium.org, Jan 25 2017

Issue description

Some configurations of MSVS are failing to compiling generated catalog sources because the resulting string constant is too large.
 

Comment 1 by roc...@chromium.org, Jan 25 2017

Cc: deadbeef@chromium.org roc...@chromium.org
 Issue 685360  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54f7f1152bc29db13f40cf6c013f1334fc257a02

commit 54f7f1152bc29db13f40cf6c013f1334fc257a02
Author: rockot <rockot@chromium.org>
Date: Thu Jan 26 05:00:09 2017

Revert to using on-disk catalog manifest for views mus tests

This catalog is too large to fit into a string constant under
certain MSVS configurations. We'll need an alternative way
to generate the manifest sources.

BUG= 685359 
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2654173002
Cr-Commit-Position: refs/heads/master@{#446230}

[modify] https://crrev.com/54f7f1152bc29db13f40cf6c013f1334fc257a02/ui/views/mus/BUILD.gn
[modify] https://crrev.com/54f7f1152bc29db13f40cf6c013f1334fc257a02/ui/views/mus/views_mus_test_suite.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72cb24d232fb79d878f8c0ab16b736e207d9c355

commit 72cb24d232fb79d878f8c0ab16b736e207d9c355
Author: rockot <rockot@chromium.org>
Date: Thu Jan 26 19:47:52 2017

Generate better catalog C++ sources

Rather than dumping a simple string literal, which has unacceptable
limitations due to arbitrary string literal length constraints in
compilers, we instead parse the JSON at build time and emit a C++
function which returns a fixed base::Value representation of that JSON.

BUG= 685359 
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2659523002
Cr-Commit-Position: refs/heads/master@{#446404}

[modify] https://crrev.com/72cb24d232fb79d878f8c0ab16b736e207d9c355/chrome/app/mash/BUILD.gn
[modify] https://crrev.com/72cb24d232fb79d878f8c0ab16b736e207d9c355/chrome/app/mash/mash_runner.cc
[add] https://crrev.com/72cb24d232fb79d878f8c0ab16b736e207d9c355/services/catalog/public/tools/catalog.cc.tmpl
[modify] https://crrev.com/72cb24d232fb79d878f8c0ab16b736e207d9c355/services/catalog/public/tools/catalog.gni
[add] https://crrev.com/72cb24d232fb79d878f8c0ab16b736e207d9c355/services/catalog/public/tools/catalog.h.tmpl
[modify] https://crrev.com/72cb24d232fb79d878f8c0ab16b736e207d9c355/services/catalog/public/tools/sourcify_manifest.py
[modify] https://crrev.com/72cb24d232fb79d878f8c0ab16b736e207d9c355/services/service_manager/public/cpp/test/run_all_service_tests_with_catalog.cc
[modify] https://crrev.com/72cb24d232fb79d878f8c0ab16b736e207d9c355/services/service_manager/public/cpp/test/service_test_catalog.h
[modify] https://crrev.com/72cb24d232fb79d878f8c0ab16b736e207d9c355/services/service_manager/public/tools/test/service_test.gni

Comment 4 by roc...@chromium.org, Jan 26 2017

Status: Fixed (was: Assigned)

Sign in to add a comment