New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 685358 link

Starred by 1 user
Status: Fixed
Owner:
mfo...@chromium.org
Closed: Oct 2017
Cc:
█ imch...@chromium.org
█ avayvod@chromium.org
steimel@chromium.org
dcheng@chromium.org
█ shenwang@google.com
mfo...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

[PresentationAPI] Unique origins should not be considered same-origin for Cast

Project Member Reported by mfo...@chromium.org, Jan 25 2017 
I don't have a repro case, but looking at the existing Cast MRP code in Android it looks like unique origins (e.g., from sandboxed iframes) all get serialized to "", which makes them same-origin from the perspective of the Cast SDK.  I don't think this makes sense, or at least it's not the intent of the SDK to behave this way.

See, e.g. 

https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java?rcl=0&l=438

This bug tracks the work to treat unique origins correctly in the Cast MRP.  It should be a one-line fix.

Comment 1 by sko...@chromium.org, Jan 26 2017

Status: Available (was: Untriaged)

Comment 2 by mfo...@chromium.org, Jan 30 2017

Labels: ClankMRHotlist

Comment 3 by dcheng@chromium.org, Feb 5 2017

Cc: dcheng@chromium.org

Comment 4 by mfo...@chromium.org, Sep 29 2017

Owner: mfo...@chromium.org
Status: Assigned (was: Available)

Comment 5 by dcheng@chromium.org, Sep 30 2017 

Should the bug title be "shouldn't be considered same-origin"?

Comment 6 by mfo...@chromium.org, Sep 30 2017

Summary: [PresentationAPI] Unique origins should not be considered same-origin for Cast (was: [PresentationAPI] Unique origins should be considered same-origin for Cast)

Comment 7 by mfo...@chromium.org, Oct 3 2017

Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51d2d0d050d25d362409cf24b08a3033d0e261e7

commit 51d2d0d050d25d362409cf24b08a3033d0e261e7
Author: mark a. foltz <mfoltz@chromium.org>
Date: Wed Oct 04 23:27:06 2017

[Media Router] Correct origin comparison for unique origins.

Fix Android implementation of Media Router to handle empty (unique)
origins properly through custom comparison.

Adds unit tests and removes redundant code from existing tests.

Bug:  685358 
Change-Id: I051e5d7856f4fb9476166aa1ddda170bef2d5983
Reviewed-on: https://chromium-review.googlesource.com/699738
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Zhiqiang Zhang <zqzhang@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506564}
[modify] https://crrev.com/51d2d0d050d25d362409cf24b08a3033d0e261e7/chrome/android/java/src/org/chromium/chrome/browser/media/router/MediaRouteProvider.java
[modify] https://crrev.com/51d2d0d050d25d362409cf24b08a3033d0e261e7/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProvider.java
[modify] https://crrev.com/51d2d0d050d25d362409cf24b08a3033d0e261e7/chrome/android/junit/src/org/chromium/chrome/browser/media/router/cast/CastMediaRouteProviderTest.java
[modify] https://crrev.com/51d2d0d050d25d362409cf24b08a3033d0e261e7/chrome/browser/media/android/router/media_router_android_bridge.cc

Comment 9 by mfo...@chromium.org, Oct 4 2017

Status: Fixed (was: Started)
►

Sign in to add a comment